adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
12.53k stars 1.08k forks source link

Buttons don't get pressed using Vimium #6747

Closed freisenhauer closed 1 month ago

freisenhauer commented 1 month ago

Provide a general summary of the issue here

If using vimium in Chrome or Firefox, Buttons onPress Functions dont get called.

๐Ÿค” Expected Behavior?

The Button should trigger the onPress function.

๐Ÿ˜ฏ Current Behavior

The Button just shortly displays the browser indication that the button was navigated (in Chrome light blue borders).

๐Ÿ’ Possible Solution

No response

๐Ÿ”ฆ Context

Here you can see, which events vimium triggers to simulate a click: https://github.com/philc/vimium/blob/master/lib/dom_utils.js#L367

simulateClick(element, modifiers) {
    if (modifiers == null) modifiers = {};
    const eventSequence = [
      "pointerover",
      "mouseover",
      "pointerdown",
      "mousedown",
      "pointerup",
      "mouseup",
      "click",
    ];
    for (const event of eventSequence) {
      this.simulateMouseEvent(event, element, modifiers);
    }
  },

๐Ÿ–ฅ๏ธ Steps to Reproduce

Version

latest

What browsers are you seeing the problem on?

Firefox, Chrome

If other, please specify.

No response

What operating system are you using?

MacOS

๐Ÿงข Your Company/Team

No response

๐Ÿ•ท Tracking Issue

https://github.com/mittwald/flow/issues/590

snowystinger commented 1 month ago

This might start working after https://github.com/adobe/react-spectrum/issues/1720, specifically once we remove the hitbox testing which used to be required and theoretically is removable now.

LFDanLu commented 1 month ago

Closing as a dupe of https://github.com/adobe/react-spectrum/issues/1720, we can reopen if it doesn't get resolved by getting rid of the hitbox testing.

Georgegriff commented 1 month ago

Closing as a dupe of #1720, we can reopen if it doesn't get resolved by getting rid of the hitbox testing.

How likely is this to happen #1720 has been open since 2021?

snowystinger commented 1 month ago

We'd very much like to do it. We just haven't had the bandwidth yet. We accept contributions if you or anyone would be interested in pitching in.