adobe / react-spectrum

A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
12.73k stars 1.09k forks source link

S2 Card updates #7053

Closed devongovett closed 1 week ago

devongovett commented 1 week ago

Three changes from conversation with design:

  1. Make the white inner stroke for selected quiet cards with highlight selection more subtle, by making it partially transparent. I believe this still passes contrast, and it also matches the overlay around the checkbox when that appears.
  2. Prevent the gap between the title and description from expanding when an action button is present. The action button is taller than a single line of text so it makes the grid row taller, making it appear like there's more space. Now the button overlaps the gap and doesn't change the height of the row.
  3. When resizing a CardView with waterfall layout, the cards seemed to jump around since we always chose the shortest column to append to during layout and this could change due to small changes in text wrapping, etc. Now we store the current column index for each card and try to preserve that so cards don't jump around unless the number of columns changes.
rspbot commented 1 week ago

Build successful! 🎉