issues
search
adobe
/
react-spectrum
A collection of libraries and tools that help you build adaptive, accessible, and robust user experiences.
https://react-spectrum.adobe.com
Apache License 2.0
13.08k
stars
1.14k
forks
source link
fix: Accordion release fixes
#7391
Closed
reidbarber
closed
1 week ago
reidbarber
commented
1 week ago
Updates v3
DisclosureHeader
to be
DisclosureTitle
to match S2 API
Updates S2 Disclosure JSDoc
Remove controlled stories from S2 Accordion storybook docs build
โ Pull Request Checklist:
[ ] Included link to corresponding
React Spectrum GitHub Issue
.
[ ] Added/updated unit tests and storybook for this change (for new code or code which already has tests).
[ ] Filled out test instructions.
[ ] Updated documentation (if it already exists for this component).
[ ] Looked at the Accessibility Practices for this feature -
Aria Practices
๐ Test Instructions:
๐งข Your Project:
rspbot
commented
1 week ago
Build successful! ๐
View the storybook
View the storybook-19
View the storybook-17
View the storybook-16
View the S2 storybook
View the documentation
rspbot
commented
1 week ago
Build successful! ๐
View the storybook
View the storybook-19
View the storybook-17
View the storybook-16
View the S2 storybook
View the documentation
rspbot
commented
1 week ago
## API Changes ### @react-spectrum/accordion #### /@react-spectrum/accordion:DisclosureHeader ```diff -DisclosureHeader { - UNSAFE_className?: string - UNSAFE_style?: CSSProperties - alignSelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'center' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'stretch'> - aria-describedby?: string - aria-details?: string - aria-label?: string - aria-labelledby?: string - bottom?: Responsive
- children: React.ReactNode - end?: Responsive
- flex?: Responsive
- flexBasis?: Responsive
- flexGrow?: Responsive
- flexShrink?: Responsive
- gridArea?: Responsive
- gridColumn?: Responsive
- gridColumnEnd?: Responsive
- gridColumnStart?: Responsive
- gridRow?: Responsive
- gridRowEnd?: Responsive
- gridRowStart?: Responsive
- height?: Responsive
- id?: string - isHidden?: Responsive
- justifySelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'center' | 'left' | 'right' | 'stretch'> - left?: Responsive
- level?: number = 3 - margin?: Responsive
- marginBottom?: Responsive
- marginEnd?: Responsive
- marginStart?: Responsive
- marginTop?: Responsive
- marginX?: Responsive
- marginY?: Responsive
- maxHeight?: Responsive
- maxWidth?: Responsive
- minHeight?: Responsive
- minWidth?: Responsive
- order?: Responsive
- position?: Responsive<'static' | 'relative' | 'absolute' | 'fixed' | 'sticky'> - right?: Responsive
- start?: Responsive
- top?: Responsive
- width?: Responsive
- zIndex?: Responsive
-} ``` #### /@react-spectrum/accordion:SpectrumDisclosureHeaderProps ```diff -SpectrumDisclosureHeaderProps { - UNSAFE_className?: string - UNSAFE_style?: CSSProperties - alignSelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'center' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'stretch'> - aria-describedby?: string - aria-details?: string - aria-label?: string - aria-labelledby?: string - bottom?: Responsive
- children: React.ReactNode - end?: Responsive
- flex?: Responsive
- flexBasis?: Responsive
- flexGrow?: Responsive
- flexShrink?: Responsive
- gridArea?: Responsive
- gridColumn?: Responsive
- gridColumnEnd?: Responsive
- gridColumnStart?: Responsive
- gridRow?: Responsive
- gridRowEnd?: Responsive
- gridRowStart?: Responsive
- height?: Responsive
- id?: string - isHidden?: Responsive
- justifySelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'center' | 'left' | 'right' | 'stretch'> - left?: Responsive
- level?: number = 3 - margin?: Responsive
- marginBottom?: Responsive
- marginEnd?: Responsive
- marginStart?: Responsive
- marginTop?: Responsive
- marginX?: Responsive
- marginY?: Responsive
- maxHeight?: Responsive
- maxWidth?: Responsive
- minHeight?: Responsive
- minWidth?: Responsive
- order?: Responsive
- position?: Responsive<'static' | 'relative' | 'absolute' | 'fixed' | 'sticky'> - right?: Responsive
- start?: Responsive
- top?: Responsive
- width?: Responsive
- zIndex?: Responsive
-} ``` #### /@react-spectrum/accordion:DisclosureTitle ```diff +DisclosureTitle { + UNSAFE_className?: string + UNSAFE_style?: CSSProperties + alignSelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'center' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'stretch'> + aria-describedby?: string + aria-details?: string + aria-label?: string + aria-labelledby?: string + bottom?: Responsive
+ children: React.ReactNode + end?: Responsive
+ flex?: Responsive
+ flexBasis?: Responsive
+ flexGrow?: Responsive
+ flexShrink?: Responsive
+ gridArea?: Responsive
+ gridColumn?: Responsive
+ gridColumnEnd?: Responsive
+ gridColumnStart?: Responsive
+ gridRow?: Responsive
+ gridRowEnd?: Responsive
+ gridRowStart?: Responsive
+ height?: Responsive
+ id?: string + isHidden?: Responsive
+ justifySelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'center' | 'left' | 'right' | 'stretch'> + left?: Responsive
+ level?: number = 3 + margin?: Responsive
+ marginBottom?: Responsive
+ marginEnd?: Responsive
+ marginStart?: Responsive
+ marginTop?: Responsive
+ marginX?: Responsive
+ marginY?: Responsive
+ maxHeight?: Responsive
+ maxWidth?: Responsive
+ minHeight?: Responsive
+ minWidth?: Responsive
+ order?: Responsive
+ position?: Responsive<'static' | 'relative' | 'absolute' | 'fixed' | 'sticky'> + right?: Responsive
+ start?: Responsive
+ top?: Responsive
+ width?: Responsive
+ zIndex?: Responsive
+} ``` #### /@react-spectrum/accordion:SpectrumDisclosureTitleProps ```diff +SpectrumDisclosureTitleProps { + UNSAFE_className?: string + UNSAFE_style?: CSSProperties + alignSelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'center' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'stretch'> + aria-describedby?: string + aria-details?: string + aria-label?: string + aria-labelledby?: string + bottom?: Responsive
+ children: React.ReactNode + end?: Responsive
+ flex?: Responsive
+ flexBasis?: Responsive
+ flexGrow?: Responsive
+ flexShrink?: Responsive
+ gridArea?: Responsive
+ gridColumn?: Responsive
+ gridColumnEnd?: Responsive
+ gridColumnStart?: Responsive
+ gridRow?: Responsive
+ gridRowEnd?: Responsive
+ gridRowStart?: Responsive
+ height?: Responsive
+ id?: string + isHidden?: Responsive
+ justifySelf?: Responsive<'auto' | 'normal' | 'start' | 'end' | 'flex-start' | 'flex-end' | 'self-start' | 'self-end' | 'center' | 'left' | 'right' | 'stretch'> + left?: Responsive
+ level?: number = 3 + margin?: Responsive
+ marginBottom?: Responsive
+ marginEnd?: Responsive
+ marginStart?: Responsive
+ marginTop?: Responsive
+ marginX?: Responsive
+ marginY?: Responsive
+ maxHeight?: Responsive
+ maxWidth?: Responsive
+ minHeight?: Responsive
+ minWidth?: Responsive
+ order?: Responsive
+ position?: Responsive<'static' | 'relative' | 'absolute' | 'fixed' | 'sticky'> + right?: Responsive
+ start?: Responsive
+ top?: Responsive
+ width?: Responsive
+ zIndex?: Responsive
+} ``` -----------------------------------
DisclosureHeader
to beDisclosureTitle
to match S2 APIโ Pull Request Checklist:
๐ Test Instructions:
๐งข Your Project: