Closed cuberoot closed 5 years ago
Fix web components that are mounted into a container so that they clean up the div that they create.
container
div
Remove the div that is created when the web component in unmounted
https://github.com/adobe/react-webcomponent/issues/11
I have a case where I am mounting/unmounting a component (popover) and the divs are piling up.
See the test that I added in the PR to detect this. It fails without my change to WebComponent
WebComponent
Thanks for the contribution @cuberoot
Fix web components that are mounted into a
container
so that they clean up thediv
that they create.Description
Remove the
div
that is created when the web component in unmountedRelated Issue
https://github.com/adobe/react-webcomponent/issues/11
Motivation and Context
I have a case where I am mounting/unmounting a component (popover) and the
div
s are piling up.How Has This Been Tested?
See the test that I added in the PR to detect this. It fails without my change to
WebComponent
Types of changes
Checklist: