search

adobe / react-webcomponent

This projects automates the wrapping of a React component in a CustomElement.
Apache License 2.0
105 stars 19 forks source link

byContentVal does not update in cases where there are no children #14

Open cuberoot opened 5 years ago

cuberoot commented 5 years ago

Expected Behaviour

A simple model like this should update if the contents of the node changes:

class ButtonModel extends DOMModel {
    @byContentVal() label;
}

Actual Behaviour

The initial contents of the DOM node is read, but the model does not respond to changes

Reproduce Scenario (including but not limited to)

Any use of the byContentVal decorator that isn't in a child node

Steps to Reproduce

I will submit a PR that includes a test case

Platform and Version

Chrome 72, MacOS

Sample Code that illustrates the problem

I will submit a PR that includes a test case

Logs taken while reproducing problem