search

adobe / react-webcomponent

This projects automates the wrapping of a React component in a CustomElement.
Apache License 2.0
105 stars 19 forks source link

Bycontentval fix ws #17

Closed adixon-adobe closed 5 years ago

adixon-adobe commented 5 years ago

Description

Makes the byContentVal decorator update like the other decorators, even when not used in a child node. Related Issue

14

Motivation and Context

We have some UI that does not update because of this issue How Has This Been Tested?

I have tested this in my application, and I have included a test case Screenshots (if appropriate): Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)

New feature (non-breaking change which adds functionality)

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x ] I have signed the Adobe Open Source CLA.
[x ] My code follows the code style of this project.

My change requires a change to the documentation. I have updated the documentation accordingly. [x ] I have read the CONTRIBUTING document. [x ] I have added tests to cover my changes. [x ] All new and existing tests passed.

adixon-adobe commented 5 years ago

@adobe/open-source-office I'm an Adobe employee -- can you approve me please?

cuberoot commented 5 years ago

@adixon-adobe I fixed up the white space in my pull on the weekend, so we can close this.

alexmirea commented 5 years ago

Yes, let's close this one as it seems to be the same asa https://github.com/adobe/react-webcomponent/pull/15