search

adobe / react-webcomponent

This projects automates the wrapping of a React component in a CustomElement.
Apache License 2.0
105 stars 19 forks source link

Infinite loop with Redux and @byChildrenRefArray #6

Closed niekraaijmakers closed 5 years ago

niekraaijmakers commented 5 years ago

I am not sure if we are already aware of this,

But using the annotation byChildrenRefArray in combination with Redux seems to trigger an infinite loop.

The only thing needed to reproduce this is putting an @byChildrenRefArray in a DOM Model that will be used to initialize a controller that uses Redux .

1) My question is, are we aware of this 2) Can this be reproduced by using our internal projects or should I provide a sophisticated example?

Thanks !

alexmirea commented 5 years ago

Hi Niek! Thanks for bringing this up, so far we are not aware of such issues, as far as I know it has we have used redux with the library not sure exactly if this decorator.

Could you please explain a bit more the usecase - if you cannot put the internal one maybe steps to reproduce it, Redux does a lot of things and I am not sure where the loop would be. So it you could point to a example would be great!

Thanks!

niekraaijmakers commented 5 years ago

Seems to be fixed now right? I think we can close it.