adobe / reactor-extension-core

This is the Core extension for Adobe Experience Platform Tags. It provides default event, condition, action, and data element types to all Tags properties.
https://experienceleague.adobe.com/docs/experience-platform/tags/extensions/adobe/core/overview.html
Apache License 2.0
21 stars 13 forks source link

Adding new Data Elements to reduce the need for Custom Code #54

Closed frederikwerner closed 3 years ago

frederikwerner commented 3 years ago

Description

This pull requests adds four new Data Elements:

Related Issue

51

Motivation and Context

As described in #51, this pull requests adds Data Elements that aim to reduce the need for Custom Code Data Elements to

In my current and every previous company, we need to maintain our own private extension to have the described functionality. I know that we are not alone with this, so I feel like that basic functionality should be included in the Core extension so that it can be maintained centrally. There is not a lot of actual "logic" in those Data Elements, they just help us to keep our Launch properties maintainable for non-developers by avoiding tons of custom code in Data Elements (or even conditions). If any of the functionality would find its way into the Core extension, we would be super happy.

Screenshots (if appropriate):

image image image image

Types of changes

Checklist:

tyssejc commented 3 years ago

Nice work @frederikwerner ! If this doesn't get pulled into the core extension, a lot of people would use it as a separate extension (myself included).

zkorczyc commented 3 years ago

I am So for it. It is a cool ad on that I have already ideas how to use.

anilytics commented 3 years ago

This is great stuff @frederikwerner Hope this makes it.

patrickhegnauer commented 3 years ago

Nice work :), I do have most of them also in a private extension. A timestamp data element is also very useful, where you can config the format as preferred e.g. YYYY-MM-DD HH:MM:SS

dompuiu commented 3 years ago

@frederikwerner We made some changes starting from your code and we now have this PR: https://github.com/adobe/reactor-extension-core/pull/61 . Thank you for your contribution!

I will close the current PR.