search

adobe / reactor-extension-core

This is the Core extension for Adobe Experience Platform Tags. It provides default event, condition, action, and data element types to all Tags properties.
https://experienceleague.adobe.com/docs/experience-platform/tags/extensions/adobe/core/overview.html
Apache License 2.0
21 stars 13 forks source link

Change "Conditional Value" data element type's description of returned values #64

Closed yuhui closed 3 years ago

yuhui commented 3 years ago

Expected Behaviour

The descriptions for the returned values should be changed so that they don't indicate that only string values are returned.

Based on https://github.com/adobe/reactor-extension-core/blob/ec17a5f7074133466587fd42216fdc717ed7a3f9/src/view/dataElements/conditionalValue.jsx#L104-L118, returned values are returned with their types as-is. The exception is for number-like values, which are cast to a Number type (which itself is a debatable casting).

For example:

If the return conditional value is returned in a Rule, then Launch returns "my key-value object" as its Object type. Launch does not return the string version of "my key-value object".

Given this logic, there is no good reason to state that a string value is returned.

Actual Behaviour

Screenshot 2021-09-25 at 12 50 06 PM

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Sample Code that illustrates the problem

Logs taken while reproducing problem

markhicken commented 3 years ago

@adobe export issue to Jira project PDCL as Task

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue PDCL-6898 is successfully created for this GitHub issue.

dompuiu commented 3 years ago

Fixed in 3.2.2.