blackout-next(4) Pdcl 6794 modern approach enters viewport - Githubissues

adobe / reactor-extension-core

This is the Core extension for Adobe Experience Platform Tags. It provides default event, condition, action, and data element types to all Tags properties.

https://experienceleague.adobe.com/docs/experience-platform/tags/extensions/adobe/core/overview.html

Apache License 2.0

21 stars 13 forks source link

blackout-next(4) Pdcl 6794 modern approach enters viewport #77

Closed brenthosie closed 1 year ago

brenthosie commented 1 year ago

Description

Related Issue

https://jira.corp.adobe.com/browse/PDCL-6794

Motivation and Context

Addresses #60 to remove polling timing code from the entersViewport logic.
Bumps some dependencies.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] I have updated the Experience League documentation for the Core Extension
[x] All tests pass and I've made any necessary test changes.
[x] I have run the extension sandbox successfully.

brenthosie commented 1 year ago

@dompuiu Here's CI run on the latest commit: https://github.com/adobe/reactor-extension-core/actions/runs/4227608746/jobs/7342250139

Let's start a review.

brenthosie commented 1 year ago

Latest CI Run for commit c3b6fe762afbf5aaf4cf98a2dde4c683102d8319