Auto build & package - Githubissues

adobe / reactor-extension-core

This is the Core extension for Adobe Experience Platform Tags. It provides default event, condition, action, and data element types to all Tags properties.

https://experienceleague.adobe.com/docs/experience-platform/tags/extensions/adobe/core/overview.html

Apache License 2.0

21 stars 13 forks source link

Auto build & package #86

Closed markhicken closed 2 months ago

markhicken commented 2 months ago

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] I have signed the Adobe Open Source CLA.
[ ] My code follows the code style of this project.
[ ] I have updated the Experience League documentation for the Core Extension
[ ] All tests pass and I've made any necessary test changes.
[ ] I have run the extension sandbox successfully.

jbarchibald commented 2 months ago

Looks like this did compile OK, where would i look to find this dist/ folder?

markhicken commented 2 months ago

Looks like this did compile OK, where would i look to find this dist/ folder?

See https://github.com/actions/upload-artifact?tab=readme-ov-file#outputs

here's the build with artifacts... https://github.com/adobe/reactor-extension-core/actions/runs/10460021011

Also, I need to update it to only upload the packaged zip file rather than the whole dist folder.

markhicken commented 2 months ago

Ok, I have this fixed. It now only uploads the extension package. The key is that it needs to be versioned as part of the PR. The workflow log now echos a direct link to the artifact.

@brenthosie are you aware of any CI constraints (build limits, storage limits, etc)? We might need to periodically cleanup old builds if they don't do it for us.

markhicken commented 2 months ago

Ok, apparently renaming the branch closes the PR. :(

Moved to new PR over here.