search

adobe / reactor-packager

Command line utility for packaging an Adobe Experience Platform Tags extension into a zip file.
Apache License 2.0
8 stars 6 forks source link

Maximum call stack size exceeded #18

Closed alcazes closed 3 years ago

alcazes commented 3 years ago

When I run npx @adobe/reactor-packager, a zip file is generated but it is empty and in the console I get this: Maximum call stack size exceeded. It literally just display this without any error.

Any idea what I am doing wrong?

Thanks

alcazes commented 3 years ago

Closing this as it does not seem anybody is monitoring these issues.

Issue seems that Adobe Launch packager does not handle well instances where extension contains several .js files that make reference to each other using require. At some point Maximum call stack size exceeded will happen.

Solution was to move all of the functions into one files instead of splitting them in multiple files.

spencerroan commented 3 years ago

@alcazes, these issues are indeed monitored, though we don't have a guaranteed response time.

The team as a whole has been enjoying some much needed time off from an unprecedented year celebrating Thanksgiving. This error will be prioritized in our next triage.

thebenrob commented 3 years ago

@alcazes, @jhicken from our eng team has suggested that you double-check all the paths as well as adding the .js to all your require statements. Apparently many of the packagers out there have some included magic to resolve ambiguous file paths and automatically add file extensions, but that the packager is not one of them. But there should be no maximum to the number of files that an extension package can contain.

Aaronius commented 3 years ago

Apparently many of the packagers out there have some included magic to resolve ambiguous file paths and automatically add file extensions, but that the packager is not one of them.

The packager allows for not specifying the file extension: https://github.com/adobe/reactor-packager/blob/c4571b9e47d77ab8ca004d9eca54a3a0d3702a69/tasks/helpers/getPackagePaths.js#L39-L40

If we're seeing different behavior, it's a bug.

jhicken commented 3 years ago

Thanks @Aaronius

brenthosie commented 3 years ago

@alcazes Do you have a way to reproduce this and share it with me so I can diagnose what's going on?

alcazes commented 3 years ago

@brenthosie I have created the following support ticket with Adobe https://adminconsole.adobe.com/C50417FE52CB33480A490D4C@AdobeOrg/support/support-cases/E-000357711 and attached the zip file which contains the project that created the issue at the time.

I have now moved away from using the structure for the same project and fully refactored it. It now works just fine.