search

adobe / reactor-packager

Command line utility for packaging an Adobe Experience Platform Tags extension into a zip file.
Apache License 2.0
8 stars 6 forks source link

core-js deprecated warning when installing #19

Closed yuhui closed 2 years ago

yuhui commented 3 years ago

When running npx @adobe/reactor-packager for the first time, a deprecated warning for core-js is listed.

Expected Behaviour

No warnings are listed.

Actual Behaviour

Warnings appear.

Reproduce Scenario (including but not limited to)

macOS Big Sur 11.0.1 node 15.2.1 npm 7.0.8

node and npm installed with brew.

Steps to Reproduce

  1. Run npx @adobe/reactor-packager

Sample Code that illustrates the problem

yuhui@computer launch-extension-folder % npx @adobe/reactor-packager
Need to install the following packages:
  @adobe/reactor-packager
Ok to proceed? (y) y
npm WARN deprecated core-js@2.6.12: core-js@<3 is no longer maintained and not recommended for usage due to the number of issues. Please, upgrade your dependencies to the actual version of core-js@3.
brenthosie commented 3 years ago

@yuhui Thanks for the report, I will look into bumping the dependency causing the problem soon.

yuhui commented 3 years ago

Updated set of warnings

Environment: node 16.1.0 npm 7.11.2

npm WARN deprecated core-js@2.6.12: core-js@<3.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Please, upgrade your dependencies to the actual version of core-js.
thebenrob commented 3 years ago

@adobe export issue to Jira project PDCL

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue PDCL-6250 is successfully created for this GitHub issue.