PDCL-4836: save yargs as a dependency, not a dev dependency. - Githubissues

adobe / reactor-packager

Command line utility for packaging an Adobe Experience Platform Tags extension into a zip file.

Apache License 2.0

8 stars 6 forks source link

PDCL-4836: save yargs as a dependency, not a dev dependency. #28

Closed brenthosie closed 3 years ago

brenthosie commented 3 years ago

Description

Saves yargs as a runtime depdendency.

Related Issue

https://jira.corp.adobe.com/browse/PDCL-4836

Motivation and Context

Yargs was saved into the dev dependency block, which means packager breaks when using npx

How Has This Been Tested?

npm test
Will manually verify npx usages work after npm deployment.

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

brenthosie commented 3 years ago

Before fix:

Screen Shot 2021-04-19 at 10 00 22 AM

After fix:

Screen Shot 2021-04-19 at 10 00 37 AM