adobe / reactor-sandbox

Tasks for creating a sandbox for manually testing Adobe Experience Platform Tags extensions.
Apache License 2.0
7 stars 15 forks source link

PDCL-5745: fix duplicate extension modules #57

Closed brenthosie closed 3 years ago

brenthosie commented 3 years ago

PDCL-5745: filter out loading descriptors nested within dependencies if they don't match the platform of the main extension.json at the root project.

Description

When duplicate module paths are pulled in during descriptor resolution, it's possible that we're loading code for the wrong platform. This manifested by observing trying to test the core-extension but the core-extension-edge modules were used instead since they're a dependency of the sandbox tool.

Related Issue

https://jira.corp.adobe.com/browse/PDCL-5745

Motivation and Context

Could not accurately test the core extension in sandbox anymore. It also seemed like it could be a bigger problem as the same extensions are made for both client and server side.

How Has This Been Tested?

manual verification

Screenshots (if appropriate):

Types of changes

Checklist: