adobe / reactor-sandbox

Tasks for creating a sandbox for manually testing Adobe Experience Platform Tags extensions.
Apache License 2.0
7 stars 15 forks source link

Pdcl 5919 hide features from mobile developers #59

Closed brenthosie closed 3 years ago

brenthosie commented 3 years ago

The sandbox introduced the concept of the Library Editor & Library Sandbox, but didn't consider that these features don't make sense in the context of Mobile extension development. After discussing w/ Dan Grossen, we decided it is just best to hide these features from the user.

Description

  1. Hides the menu options for Lib Editor and Lib Sandbox if your extension platform is 'mobile'.
  2. Redirects any attempt to circumvent the UI to access Lib Editor or Lib Sandbox to the home page.
  3. Redirects Unknown routes back to the home page
  4. Introduces PLATFORMS as a constant

Related Issue

Motivation and Context

How Has This Been Tested?

https://jira.corp.adobe.com/browse/PDCL-5919

Screenshots (if appropriate):

Mobile Extension Development

Screen Shot 2021-04-28 at 2 43 55 PM

Web Extension Development

Screen Shot 2021-04-28 at 2 44 52 PM

Types of changes

Checklist:

Aaronius commented 3 years ago

In your screenshots, the part that says "and your logic that will run within a Launch library on a Launch customer's website" is only applicable when it's a web extension. You might want to make this piece of the text conditionally shown or re-work the text somehow.

brenthosie commented 3 years ago

Resolves https://github.com/adobe/reactor-sandbox/issues/58