search

adobe / reactor-sdk-javascript

JavaScript SDK for the Reactor API
Apache License 2.0
12 stars 10 forks source link

Reactor-SDK-Javascript: Fix Integration Tests #72

Open brenthosie opened 3 years ago

brenthosie commented 3 years ago

Expected Behaviour

The integration tests should run in a CI environment

Actual Behaviour

Due to new release procedures, we aren't currently running these

brenthosie commented 3 years ago

@adobe export issue to Jira project PDCL as Story

github-jira-sync-bot commented 3 years ago

:white_check_mark: Jira issue PDCL-6333 is successfully created for this GitHub issue.

brenthosie commented 3 years ago

Does this help get integration up and running? https://v2.parceljs.org/configuration/package-json/#main-%2F-module-%2F-browser

Need to resolve the "targets", "main", and "default" blocks.

dompuiu commented 3 years ago

I think that we the 2 integration suites that are targeting the browser are identical: https://github.com/adobe/reactor-sdk-javascript/blob/master/package.json#L50-L51

I think it's enough to run only one of those tests.

celesterobinson commented 3 years ago

The node integration tests are functioning. ~You can get the bundled and library tests to run by removing the engines block from the top level of the package.json. It seems like there might be a parcel bug. I'll be reporting an issue once I can replicate it on a smaller scale.~

celesterobinson commented 3 years ago

The integration tests for bundled and library currently won't build. In order to run the node ones, run integration:build:node, then integration:run. Running integration-tests will fail currently. This needs to be fixed.