liljenback commented 1 year ago

Description

Access Token can be stored in a file and used when authenticating.

Related Issue

Maybe:

63

Motivation and Context

I had problems uploading an extension.

How Has This Been Tested?

I included tests.

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

brenthosie commented 1 year ago

@liljenback Thank you for putting in the effort to make a submission to the project. After an internal discussion on your proposed change, we'd prefer to accept the --access-token as a raw string value rather than implying it's stored in a file on the user's machine. This would allow the passing of the token securely using CI/CD environment variables as well. If you can make that change, then we can re-review and consider the submission. Thank you!

brenthosie commented 8 months ago

@mems npm install @adobe/auth-token@next has support for the new oauth-server-to-server standard. Does that meet your need?

brenthosie commented 8 months ago

Addressed by #66 which allows you to pass in the access token as an environment variable. See v6.0.0-beta.12.

mems commented 5 months ago

@brenthosie Yes, with the use of REACTOR_IO_INTEGRATION_ACCESS_TOKEN env var

adobe / reactor-uploader

Shortcut to include an access-token in a file #64