Fix typo: substract => subtract

adobe / spectrum-css-workflow-icons

Apache License 2.0

14 stars 15 forks source link

Fix typo: substract => subtract #2

Closed ln-north closed 3 years ago

ln-north commented 3 years ago

Expected Behavior

SelectSubstract.svg
SubstractBackPath.svg
SubstractFrontSelection.svg

Actual Behavior

SelectSubtract.svg
SubtractBackPath.svg
SubtractFrontSelection.svg

ln-north commented 3 years ago

It's just typo, but renaming will be breaking change for this repo. I understand it's a little difficult you to answer this issue, so I will wait for your timing.

jianliao commented 3 years ago

Hi @ln-north, Thanks for filing the issue and contributed the PR. I've discussed and confirmed with Adobe Icon designer that instead of removing the wrong name icons, which will cause breaking changes as you pointed out, we are going to add three more icons with correct name.

I currently blocked by an adobe internal package update. I will fix this issue once I got it.

Thanks.