majornista commented 1 year ago

Description

Related Issue

27

Motivation and Context

In React-Spectrum documentation pages that include ChevronRight in the rendering of the open or closed state for <details>/<summary>, automated accessibility testing returns a warning because the page contains duplicate ids.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

jianliao commented 1 year ago

@snowystinger @majornista I will need to let @Hinschmi know as he owned the script that generate these react icon components.

jianliao commented 1 year ago

@Hinschmi please review the code change and modify your code generation script, then merge the PR when you're ready.

snowystinger commented 1 year ago

@jianliao @Hinschmi verified in RSP and upgraded, thank you!

adobe / spectrum-css-workflow-icons

fix(#27): Chevron icons: multiple elements having same id should be avoided #29