refactor: s2 icon updates

castastrophe commented 4 months ago

Description

Introducing the Spectrum 2 workflow icons! 🎉

Motivation and Context

With the rolling out of Spectrum 2's new designs, a new set of iconography has been created and with that, some improvements on how those icons are provided. To adjust for this, breaking changes have been made to this repository's architecture in order to support providing iconography in it's new format:

Spectrum CSS Workflow icons

Found in ./dist/, this folder contains the contents published to npm for @adobe/spectrum-css-workflow-icons. This package represents S2 iconography and will now ship 3 formats: components (i.e., web components), react, and svg. At the root of this package, you can find a manifest (dist/manifest.json) in JSON format of all available assets, as well as a prebuilt spritesheet for the SVGs called assets/svg-spriteSheet/icons.svg.

Note: Providing a PR preview link was out of scope for the work being done here but is planned for a future iteration.

How Has This Been Tested?

Setup

Check out this repository locally
yarn install
To preview SVG icons: yarn serve

TODO: Need to find and summarize the changed icons and list out any deprecated and new icons.

Screenshots

Types of changes

[x] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.

karstens commented 4 months ago

@castastrophe I really like what you are doing, thank you so much! How can I test this without publishing anything? Just check out the branch and build it and manually look/check the dist folder?

@Hinschmi @jianliao Are you okay with this?

jianliao commented 4 months ago

@castastrophe ~~Do I need yarn 4 for this project?~~

Never mind. It is yarn v1, I figure it out from the yarn.lock file.

jianliao commented 4 months ago

LGTM

netlify[bot] commented 3 months ago

Deploy Preview for spectrum-workflow-icons ready!

Name	Link
Latest commit	9ce1a149dd3e37638898e27ac511d47219eb4947
Latest deploy log	https://app.netlify.com/sites/spectrum-workflow-icons/deploys/66579d38487187000882648a
Deploy Preview	https://deploy-preview-36--spectrum-workflow-icons.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.