search

adobe / spectrum-css

The standard CSS implementation of the Spectrum design language.
http://opensource.adobe.com/spectrum-css/
Apache License 2.0
1.19k stars 194 forks source link

[Dialog] spectrum-Dialog--dismissable and spectrum-Dialog--fullscreen* are not compatible #1105

Open Westbrook opened 3 years ago

Westbrook commented 3 years ago

Description

Usage of .spectrum-Dialog--dismissable and its button.spectrum-Dialog-closeButton element are not compatible with .spectrum-Dialog--fullscreen* and it should be documented as such.

Currently, there are no documented usage of this combination. However, when users use these in concert the patterns are delivered in a less than palatable fashion. https://github.com/adobe/spectrum-web-components/issues/1088 We should explicitly outline that these should not be used together.

Link to documentation

https://opensource.adobe.com/spectrum-css/dialog.html

Additional context

We might also want to discuss defensively coding them out of the system. This is done in the latest code for the way that .spectrum-Dialog--dismissable will not allow the presentation of .spectrum-Dialog-buttonGroup content.

lazd commented 3 years ago

Uhg, even the fullscreen pattern is considered a contribution, it's a relic from years past. Dialog needs an overhaul...