search

adobe / spectrum-css

The standard CSS implementation of the Spectrum design language.
http://opensource.adobe.com/spectrum-css/
Apache License 2.0
1.2k stars 195 forks source link

[Slider] Range slider track is given wrong "margin-block-start" #1205

Open Westbrook opened 3 years ago

Westbrook commented 3 years ago

The roughly margin-block-start: -1px; rule in the following line:

https://github.com/adobe/spectrum-css/blob/842406ad3e9da3a652f2d76acddeba3b5d02ecc3/components/slider/index.css#L109

Is overridden as margin-block-start: 0; in the following line:

https://github.com/adobe/spectrum-css/blob/main/components/slider/index.css#L180

Naively, the following would appear to cure this situation:

margin-block: calc(var(--spectrum-slider-track-height) / -2) var(--spectrum-slider-range-track-reset);

I'd be happy to submit a PR if this seemed appropriate.

Westbrook commented 3 years ago

Might the be something that could find its way into the Express pass on this pattern?