adobe / spectrum-css

The standard CSS implementation of the Spectrum design language.
http://opensource.adobe.com/spectrum-css/
Apache License 2.0
1.18k stars 195 forks source link

chore: metadata schema validation #3059

Closed castastrophe closed 1 week ago

castastrophe commented 2 weeks ago

Description

Adds schema validation for the metadata.json assets.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Add an invalid entry to components/accordion/metadata/metadata.json:

Screenshot 2024-08-30 at 11 29 40 AM
components/accordion/metadata/metadata.json invalid
[
  {
    keyword: 'additionalProperties',
    dataPath: '',
    schemaPath: '#/additionalProperties',
    params: { additionalProperty: 'foo' },
    message: 'should NOT have additional properties'
  }
]

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  1. If components have been modified, VRTs have been run on this branch:

To-do list

changeset-bot[bot] commented 2 weeks ago

⚠️ No Changeset found

Latest commit: 99871f95b03e2f828a622c618cfd6888be398041

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 weeks ago

🚀 Deployed on https://pr-3059--spectrum-css.netlify.app

github-actions[bot] commented 2 weeks ago

File metrics

Summary

Total size: 4.10 MB*

🎉 No changes detected in any packages