fix(ComponentDetails): apply sb-unstyled className to correct version number misalignment - Githubissues

adobe / spectrum-css

The standard CSS implementation of the Spectrum design language.

http://opensource.adobe.com/spectrum-css/

Apache License 2.0

1.2k stars 195 forks source link

fix(ComponentDetails): apply sb-unstyled className to correct version number misalignment #3067

Closed cdransf closed 2 months ago

cdransf commented 2 months ago

Description

[x] applies className="sb-unstyled" to the parent DList node to correct the version number misalignment.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

Access Storybook (by fetching and running the branch or via the preview generated by this pull request).
Open any component and navigate to docs page.
Verify version number alignment.

Regression testing

Validate:

The documentation pages for at least two other components are still loading, including:

[x] The pages render correctly, are accessible, and are responsive.

If components have been modified, VRTs have been run on this branch:

[ ] VRTs have been run and looked at.
[ ] Any VRT changes have been accepted (by reviewer and/or PR author), or there are no changes.

Screenshots

Screenshot 2024-09-03 at 6 55 29 AM

To-do list

[x] I have read the contribution guidelines.
[x] I have updated relevant storybook stories and templates.
[ ] I have tested these changes in Windows High Contrast mode.
[ ] If my change impacts other components, I have tested to make sure they don't break.
[ ] If my change impacts documentation, I have updated the documentation accordingly.
[x] ✨ This pull request is ready to merge. ✨

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 2df5ae7eeb3a20832652e1f3298ebaa3638fb82f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------- | ----- | | @spectrum-css/preview | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 2 months ago

File metrics

Summary

Total size: 4.10 MB^*

🎉 No changes detected in any packages

Size determined by adding together the size of the main file for all packages in the library.

Results are not gzipped or minified.

An ASCII character in UTF-8 is 8 bits or 1 byte.

github-actions[bot] commented 2 months ago

🚀 Deployed on https://pr-3067--spectrum-css.netlify.app