adobe / spectrum-css

The standard CSS implementation of the Spectrum design language.
http://opensource.adobe.com/spectrum-css/
Apache License 2.0
1.18k stars 195 forks source link

fix(card -> action button): corrects the size and alignment of the card action button #3072

Closed cdransf closed 1 week ago

cdransf commented 1 week ago

Description

This prevents .spectrum-Card-actionButton from spilling the available space in the header and aligns the title and action button at the opposite edges of the container.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  1. Open the Storybook URL for the PR (or run against the branch locally).
  2. Navigate to the card component.
  3. Set Card actions to true
  4. Hover over the action button to verify the proper card dimensions.

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  1. If components have been modified, VRTs have been run on this branch:

Screenshots

Screenshot 2024-09-04 at 4 37 05 PM

To-do list

changeset-bot[bot] commented 1 week ago

🦋 Changeset detected

Latest commit: 16704ffbda82457ca86a8aeb96223d9673478f1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------ | ----- | | @spectrum-css/card | Minor |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions[bot] commented 1 week ago

🚀 Deployed on https://pr-3072--spectrum-css.netlify.app

github-actions[bot] commented 1 week ago

File metrics

Summary

Total size: 4.10 MB* Total change (Δ): ⬆ 0.07 KB (0.00%)

Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.

Package Size Δ
card 20.66 KB ⬆ 0.02 KB

Details #### card | File | Head | Base | Δ | | - | - | - | - | | index-base.css | 20.66 KB | 20.64 KB | ⬆ 0.02 KB (0.11%) | | index-vars.css | 20.66 KB | 20.64 KB | ⬆ 0.02 KB (0.11%) | | **index.css** | 20.66 KB | 20.64 KB | ⬆ 0.02 KB (0.11%) |