Closed cdransf closed 1 month ago
Latest commit: 4dc7f9e64234f415061227c02623140b08f84ae8
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
🚀 Deployed on https://pr-3078--spectrum-css.netlify.app
Total size: 4.11 MB* Total change (Δ): ⬆ 2.90 KB (0.07%)
Table reports on changes to a package's main file. Other changes can be found in the collapsed Details section below.
Package | Size | Δ |
---|---|---|
button | 83.96 KB | ⬆ 0.99 KB |
Do we need to ensure that this looks consistent in light mode as well? I'm seeing some introduced issues here that might need to be taken care of if so:
(In AssistivTunnel, with the High Contrast White theme):
(In Chrome, emulating forced colors and prefers-color-scheme: light):
Do we need to ensure that this looks consistent in light mode as well? I'm seeing some introduced issues here that might need to be taken care of if so:
(In AssistivTunnel, with the High Contrast White theme):
(In Chrome, emulating forced colors and prefers-color-scheme: light):
✨ Huh — it looks like the button-content-color
tokens are getting set in the button's index.css
file but not defined. Setting them on .spectrum-Button
looks good (and they can be updated by subsequent declarations specific to different states):
.spectrum-Button {
--highcontrast-button-content-color-default: ButtonText;
--highcontrast-button-content-color-hover: ButtonText;
--highcontrast-button-content-color-focus: ButtonText;
--highcontrast-button-content-color-down: ButtonText;
}
The styles aren't terribly distinct, but I imagine the available colors don't allow them to be.
Description
How and where has this been tested?
Verified in Assistiv Labs high contrast mode-enabled Windows VM.
Validation steps
negative
variant.Regression testing
Validate:
Screenshots
To-do list