search

adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.22k stars 196 forks source link

[Feat]: Action Button with Bottom Label #2063

Open najikahalsema opened 2 years ago

najikahalsema commented 2 years ago

Code of conduct

Impacted component(s)

sp-action-button

Description of the requested feature

This particular pattern has come up a few times during my work, particularly in situations where there is a toolbar or navigation element on the bottom of the screen. It is already in production in places like PS on the iPad. We have other components with properties that dictate the label's position; why not extend that behaviour to the action buttons, as well?

This work would entail adding another property to sp-action-button to set the label position, and adding the relevant CSS to display it.

Mockups or screenshots

image

Example of spec in use:

image

Implementation notes or ideas

No response

najikahalsema commented 1 year ago

We need CSS to include this before we take it on. X may have a local fix.

Westbrook commented 1 year ago

Needs inclusion in the Core Tokens measurements. Would benefit from promoting out of Spectrum Contributions world. Design decisions being gathered.

Rajdeepc commented 3 months ago

Let's wait for Spectrum 2 spec