search

adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.25k stars 200 forks source link

[Bug]: Irregular jumping of ColorHandle on the Hue slider while the handle of ColorArea moves #3058

Open prabhjodh opened 1 year ago

prabhjodh commented 1 year ago

Code of conduct

Impacted component(s)

sp-color-slider, sp-color-area

Expected behavior

No response

Actual behavior

We’re going to use the SWC’s ColorArea and ColorSlider for the color picker in a project. As we try to change the color on ColorArea while setting the Hue to some value other than 0, we get irregular jumping of color handle on the Hue slider while the color handle of ColorArea moves near the corner values (as shown in the video). The behaviour can be tried online here: https://studio.webcomponents.dev/edit/collection/fO75441E1Q5ZlI0e9pgq/kxW1VIhXBXVSOnyXhF9M/src/index.stories.js?p=stories

Screenshots

https://user-images.githubusercontent.com/20225072/227160996-e2d39db1-9f05-4cae-a87f-dba9cf816fba.mov

What browsers are you seeing the problem in?

Chrome

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

Westbrook commented 1 year ago

We're seeing this work better in https://github.com/adobe/spectrum-web-components/pull/2782, try it in https://color-js--spectrum-web-components.netlify.app/storybook/?path=/story/color-area--joint. There is a breaking type change therein that we need some more time to clarify how to manage/document/educate.