search

adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.24k stars 200 forks source link

[Bug]: sp-number-field pressing increment/decrement buttons with VO on iOS double presses buttons #3274

Open jnurthen opened 1 year ago

jnurthen commented 1 year ago

Code of conduct

Impacted component(s)

sp-number-field

Expected behavior

should be able to press buttons to increase/decrease numbers in sp-number-field

Actual behavior

pressing the buttons seems to refresh the page and moves focus AND double presses the buttons

Screenshots

No response

What browsers are you seeing the problem in?

Safari

How can we reproduce this issue?

  1. Go to https://opensource.adobe.com/spectrum-web-components/components/number-field/
  2. start VO on iOS
  3. tap on the number field
  4. swipe right to move to the increase button
  5. double tap to press the button
  6. note the keyboard activates then deactivates
  7. Focus moves to the "Show sidebar" button at the top of the page
  8. The value increases by 2 steps

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

najikahalsema commented 1 year ago

3272 #3271

These bugs are all related to the inaccessibility of the increment/decrement buttons. These will need to be tested even more thoroughly than they have before. We test for all kinds of interactions, but not the kinds that include voiceover.

TarunAdobe commented 1 year ago

Hey @jnurthen I am trying to test this bug on my phone and it seems like everything is working fine... Can you verify from your end and if there's still an issue... can you please attach a screen-recording like mine so that I can verify and start working on it.

https://github.com/adobe/spectrum-web-components/assets/137032355/7715399d-8903-451f-a772-64500d0c0d6c

jnurthen commented 1 year ago

This seems to no longer reproduce

jnurthen commented 1 year ago

Actually - just tested again. It seems to reproduce on my iPad but not my iPhone. I'll record a testcase and do some more investigation.

jnurthen commented 1 year ago

And it only reproduces when a bluetooth keyboard is connected!

jnurthen commented 1 year ago

https://github.com/adobe/spectrum-web-components/assets/1724479/e28e51c9-f4b6-4308-807d-f9bd99769c52

jnurthen commented 1 year ago

Additional info Does not reproduce on iOS 16.6 w/ Bluetooth keyboard Does reproduce on iPadOS 17.0 beta w/ Bluetooth keyboard

I don't have a beta iPhone or a non-beta iPadOS to be able to test if this is a beta issue or an iPadOS vs iOS issue

jnjosh commented 1 year ago

@TarunAdobe I tested this out on my iPad mini using iPad Os 16.6.1 with and without a Bluetooth keyboard. The interesting thing is I see this reproduce with and without the keyboard—it's just worse I think with the keyboard.

In the first video, with a Bluetooth keyboard connected (33 seconds) the button seems to actually trigger many times—going all the way up to +7. Interestingly it refocuses on the address bar.

https://github.com/adobe/spectrum-web-components/assets/66142/0f74db5a-262c-4e0d-aeda-14cdc5d0c31c

In the second video, without a Bluetooth keyboard connected (15 seconds) the button does trigger twice (going from -1 to +1). Then you can see the software keyboard flash, then refocus on the address bar again.

https://github.com/adobe/spectrum-web-components/assets/66142/9e673e8b-3601-4812-a398-adc1557809d7