Open Rajdeepc opened 7 months ago
For reference: this element, and its children continue to play a role in accessibly delivering the inputs within this pattern as long as slot content or this.label
is provided for the first and a value
is managed for the second.
When you compare the default and custom delivery of a label slider, a la https://studio.webcomponents.dev/edit/U7LQv7LsAVBwJayJXG3B/src/index.ts?branch=custom-label%40wfVpXdsTYhf9mY2slxW4t2Y2SjC3&p=stories, I don't see any visual difference in delivery.
Is it possible that the change experienced here comes from https://github.com/adobe/spectrum-web-components/pull/3581/files#diff-0b816166dc6b4aa4bce7c3c01519dbc59034f4b63ab1d4b4beef48206355a851 instead? Here we caught up with some differences between out delivery of the Slider layout and that of CSS/the specification by bringing the label and the slider closer together.
Code of conduct
Impacted component(s)
Slider
Expected behavior
When user sets
label-visibility=none
onsp-slider
the element with idlabel-container
should not be in the DOM. This is causing the sp-slider to move up with a custom label outside the shadowroot of slider.Actual behavior
If
label-visibility=none
then we should not render<div id="label-container"></div>
. This will fix the position of the sliderScreenshots
UI issue on slider. Slider track is moving up.
What browsers are you seeing the problem in?
No response
How can we reproduce this issue?
<div id="label-container"></div>
is still there which is causing the slider to move up.Sample code that illustrates the problem
Logs taken while reproducing problem
No response