adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.22k stars 191 forks source link

[Bug]: Samsung Galaxy S23 Ultra Not Considered a Small/Mobile Devoce #4262

Open croberts5 opened 2 months ago

croberts5 commented 2 months ago

Code of conduct

Impacted component(s)

sp-action-menu

Expected behavior

When opening sp-action-menu on a mobile device (any iPhone for example), the menu items are wrapped in sp-tray. When opening an action menu in a Samsung Galaxy S23 Ultra, the menu items should render in a tray.

Actual behavior

When the device is a Samsung Galaxy S23 Ultra, the menu renders in a popover like a tablet or desktop device.

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Go to SWC docs for Action menu on a Samsung Galaxy S23 Ultra device
  2. Click on '.... More Actions' button in the "Sizes" section
  3. Assert the menu items are not rendered in a tray

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

Westbrook commented 1 month ago

Can you share whether or not this decide meets the following criteria of "mobile" for our context:

najikahalsema commented 1 month ago

@croberts5 Have you been able to see if the device meets the criteria?