adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.22k stars 191 forks source link

[Bug]: Coachmark and Overlay are missing lit dependencies in 0.42.4 release #4454

Closed jcmitch closed 1 month ago

jcmitch commented 1 month ago

Code of conduct

Impacted component(s)

Coachmark, Overlay

Expected behavior

Should be able to install components without error or without needing to include additional dependencies.

Actual behavior

Error messages when running.

ModuleNotFoundError: Module not found: Error: Can't resolve 'lit/directives/join.js' in '/Users/kellencheng/component-core/packages/spectrum-web-component-fallbacks/dist/coachmark/src'

 ---and---

 ModuleNotFoundError: Module not found: Error: Can't resolve 'lit/async-directive.js' in '/Users/kellencheng/component-core/packages/spectrum-web-component-fallbacks/dist/overlay/src'

Screenshots

No response

What browsers are you seeing the problem in?

No response

How can we reproduce this issue?

  1. Attempt to install 0.42.4 outside of an environment which includes lit
  2. Attempt to use Overlay or Coachmark

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response

jcmitch commented 1 month ago

Fixed in #4455