github-actions[bot]
commented
1 month ago Closed jcmitch closed 1 month ago
github-actions[bot]
commented
1 month ago github-actions[bot]
commented
1 month ago | Category | Latest (report) | Main (report) | Branch (report) |
|---|---|---|---|
| Performance | 0.99 | 0.99 | 0.99 |
| Accessibility | 1 | 1 | 1 |
| Best Practices | 1 | 1 | 1 |
| SEO | 1 | 0.92 | 0.92 |
| PWA | 1 | 1 | 1 |
main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*
| Category | Latest | Main | Branch |
|---|---|---|---|
| Total | 222.103 kB | 210.167 kB 🏆 | 210.225 kB |
| Scripts | 54.407 kB | 47.869 kB 🏆 | 47.96 kB |
| Stylesheet | 34.873 kB | 30.497 kB | 30.451 kB 🏆 |
| Document | 5.895 kB | 5.187 kB | 5.183 kB 🏆 |
| Font | 126.928 kB | 126.614 kB 🏆 | 126.631 kB |
| Category | Latest | Main | Branch |
|---|---|---|---|
| Total | 45 | 45 | 45 |
| Scripts | 37 | 37 | 37 |
| Stylesheet | 5 | 5 | 5 |
| Document | 1 | 1 | 1 |
| Font | 2 | 2 | 2 |
github-actions[bot]
commented
1 month ago 
Rajdeepc
commented
1 month ago @jcmitch Can you please pull this up to main so that we can make sure that the code coverage is not making noise before we can land this to main. Thanks
jcmitch
commented
1 month ago @Rajdeepc done
Fixing issue with various lit imports introduced in 0.42.3 release.
Similar to https://github.com/adobe/spectrum-web-components/pull/4416 but found a few more issues that didn't show up on install but did show up when trying to upgrade. I looked at adding a
import/no-unresolvedeslint rule but ran into a few issues but we should probably look at doing this in the future.Description
Both Coachmark and Overlay included imports directly from lit while neither package has lit as a direct dependency. Moving these imports to pull from base as this seems to be the established standard.
Related issue(s)
Motivation and context
Unable to use the latest release without needing to add additional dependencies.
How has this been tested?
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.