search

adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.25k stars 200 forks source link

fix: add keyboard handlers to sp-table-cell-head #4473

Closed jnurthen closed 3 months ago

jnurthen commented 4 months ago

Description

Adds keyboard handlers to sp-table-cell-head

Related issue(s)

4472

Motivation and context

Keyboard handlers needed for accessibility.

How has this been tested?

Screenshots (if appropriate)

Types of changes

Checklist

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions[bot] commented 4 months ago

Branch preview

Visual regression test results When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs: - [High Contrast Mode | Medium | LTR](https://25a490aa061cd34e2f488fd5e022d559--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | LTR](https://60637956c86331297e7d80d328d31835--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | RTL](https://03e9df3e3f794a0267d4489308836932--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | LTR](https://159a6039cc36c1d0d225a43b0fcd7bf2--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | RTL](https://94bd3882a04bf85aba9442ca7ecd5a42--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | LTR](https://bd7eca3e64e64a6c96366ae570887894--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | RTL](https://40b07965a48251c6f4080fde9e2e0c7e--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | LTR](https://5253dff7a8a084429aabb5895c1f6a07--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | RTL](https://0d4bdb7466196d52981d62baeefa75fc--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | LTR](https://733127e60605bb30826f06af74d65136--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | RTL](https://624358c5db8daddd24646f16ebef765d--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | LTR](https://587676edc4184b0fae7356bed754c960--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | RTL](https://199b1e9749741217cbaa86fa4e19ec41--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | LTR](https://03f24045eb441bccadff9d8eb2cf9783--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | RTL](https://7abe4797d2dfa93ab13c62fe93a1dbed--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | LTR](https://a7728bdafc70876ec5c5e855f3d0499a--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | RTL](https://08b5871b083bced3320e9726bc65b84f--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | LTR](https://3651746e122b7a91b17760bbae5d5aae--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | RTL](https://39aa86cd2b2b672dd2c7a08658fa6c15--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | LTR](https://7c653f4be4a5427b2baa5a6e0ecf3266--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | RTL](https://c2fdeea395b89a1619e33c898bf5bfe2--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | LTR](https://47280c8b29ec39f4fb5426db8820cf3a--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | RTL](https://f32932526167a2bd7ec76ecdea9ddcf7--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | LTR](https://e198c815aa50bb59acd23ff73abe6d63--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | RTL](https://bb7b25ffddf5209e84f584f49b638d13--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | LTR](https://b0eb641d4d7835e3efdc44e92dd58408--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | RTL](https://9a008cf7005eb3b371f51821a2233f43--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | LTR](https://b44c6d00c8553e6cf7d8b0b220828ade--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | RTL](https://09fd9ea8ed1d14166d3639065c42b31f--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | LTR](https://198fdeab22c4bbafd092a312996b42d1--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | RTL](https://d04fe8cd64329d7d64b36b3c087d9c46--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | LTR](https://963712b91ff7614b62973aa8928c574f--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | RTL](https://102e86959ceca50d909be7e4ee95d094--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | LTR](https://57623777d30429022a333c922d5afacb--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | RTL](https://8e683ee661f17c8f5a9b88d1ff2d5271--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | LTR](https://cd2d5334f8cffa2ba3f6f033d1bb3afd--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | RTL](https://6d2fd9ce0712c02f9098dd7e979bf557--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | LTR](https://fbe670661b63dc4987f47e3154e96ea3--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | RTL](https://f5b6133235e57d9e58b936f125ce5b54--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | LTR](https://71833ab1b416fa39e665274ab582b8a4--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | RTL](https://0230d348c4fd0937d3c9b2be29c25ebe--spectrum-web-components.netlify.app/review/)
github-actions[bot] commented 4 months ago

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this? [Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category Latest Main Branch
Total 222.694 kB 210.485 kB 🏆 210.904 kB
Scripts 54.665 kB 48.269 kB 🏆 48.426 kB
Stylesheet 34.987 kB 30.308 kB 🏆 30.538 kB
Document 6.026 kB 5.304 kB 5.30 kB 🏆
Font 127.016 kB 126.604 kB 🏆 126.64 kB

Request Count

Category Latest Main Branch
Total 45 45 45
Scripts 37 37 37
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2
github-actions[bot] commented 4 months ago

Tachometer results

Chrome ## table [_permalink_](#user-content-table) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 531 kB | 122.31ms - 124.77ms | - | faster ✔
2% - 5%
2.08ms - 6.92ms | | branch | 493 kB | 125.96ms - 130.13ms | slower ❌
2% - 6%
2.08ms - 6.92ms | - |
Firefox ## table [_permalink_](#user-content-table) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 531 kB | 268.58ms - 277.70ms | - | unsure 🔍
-3% - +1%
-8.92ms - +3.96ms | | branch | 493 kB | 271.07ms - 280.17ms | unsure 🔍
-1% - +3%
-3.96ms - +8.92ms | - |