test(accordion): reorganize test files

Westbrook commented 1 month ago

Description

Break up test files into a repeatable process.

declarative.test.ts: test all declarative usage of the element in question
imperative.test.ts: all imperative interactions
keyboard.test.ts: all keyboard interactions
a11y-tree.test.ts: the delivered a11y tree across various states
controlled.test.ts: that the element can be "controlled" by the parent application
memory.test.ts: memory usage testing
dev-mode.test.ts: dev mode message for Lit and SWC

Related issue(s)

refs #4206

How has this been tested?

[ ] Test case 1
1. See that tests in CI do not fail
2. See that the coverage level does not change
3. See that the memory tests continue to be run separately

Types of changes

[x] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

github-actions[bot] commented 1 month ago

Branch preview

Visual regression test results

github-actions[bot] commented 1 month ago

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

[Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category	Latest	Main	Branch
Total	222.082 kB	210.097 kB 🏆	210.471 kB
Scripts	54.442 kB	48.064 kB 🏆	48.205 kB
Stylesheet	34.909 kB	30.255 kB 🏆	30.468 kB
Document	5.892 kB	5.181 kB 🏆	5.184 kB
Font	126.839 kB	126.597 kB 🏆	126.614 kB

Request Count

Category	Latest	Main	Branch
Total	45	45	45
Scripts	37	37	37
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

github-actions[bot] commented 1 month ago

Tachometer results

Chrome

## accordion [_permalink_](#user-content-accordion) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 416 kB | 78.22ms - 80.24ms | - | faster ✔
6% - 9%
5.05ms - 8.22ms | | branch | 403 kB | 84.64ms - 87.08ms | slower ❌
6% - 10%
5.05ms - 8.22ms | - | ## action-bar [_permalink_](#user-content-action-bar) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 484 kB | 50.85ms - 52.54ms | - | faster ✔
3% - 8%
1.34ms - 4.30ms | | branch | 472 kB | 53.30ms - 55.73ms | slower ❌
3% - 8%
1.34ms - 4.30ms | - | ## action-menu [_permalink_](#user-content-action-menu) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 647 kB | 136.46ms - 139.74ms | - | faster ✔
4% - 7%
6.10ms - 10.99ms | | branch | 634 kB | 144.83ms - 148.45ms | slower ❌
4% - 8%
6.10ms - 10.99ms | - | ### test-directive [_permalink_](#user-content-action-menu-test-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 604 kB | 62.24ms - 63.44ms | - | faster ✔
6% - 9%
4.27ms - 6.34ms | | branch | 591 kB | 67.31ms - 68.99ms | slower ❌
7% - 10%
4.27ms - 6.34ms | - | ### test-lazy [_permalink_](#user-content-action-menu-test-lazy) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 603 kB | 60.72ms - 61.87ms | - | faster ✔
5% - 8%
3.07ms - 5.00ms | | branch | 590 kB | 64.56ms - 66.11ms | slower ❌
5% - 8%
3.07ms - 5.00ms | - | ### test-open-close-directive [_permalink_](#user-content-action-menu-test-open-close-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 789 kB | 1874.91ms - 1877.52ms | - | unsure 🔍
-0% - +0%
-2.16ms - +1.92ms | | branch | 777 kB | 1874.76ms - 1877.91ms | unsure 🔍
-0% - +0%
-1.92ms - +2.16ms | - | ### test-open-close [_permalink_](#user-content-action-menu-test-open-close) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 788 kB | 1859.48ms - 1862.34ms | - | unsure 🔍
-0% - -0%
-4.66ms - -0.16ms | | branch | 775 kB | 1861.58ms - 1865.06ms | unsure 🔍
+0% - +0%
+0.16ms - +4.66ms | - | ## card [_permalink_](#user-content-card) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 502 kB | 38.57ms - 39.29ms | - | faster ✔
1% - 3%
0.19ms - 1.31ms | | branch | 489 kB | 39.25ms - 40.10ms | slower ❌
0% - 3%
0.19ms - 1.31ms | - | ## combobox [_permalink_](#user-content-combobox) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 709 kB | 35.86ms - 36.34ms | - | faster ✔
5% - 7%
1.84ms - 2.57ms | | branch | 697 kB | 38.03ms - 38.58ms | slower ❌
5% - 7%
1.84ms - 2.57ms | - | ### light-dom-test [_permalink_](#user-content-combobox-light-dom-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 709 kB | 400.77ms - 408.12ms | - | faster ✔
3% - 5%
10.54ms - 20.39ms | | branch | 697 kB | 416.64ms - 423.18ms | slower ❌
3% - 5%
10.54ms - 20.39ms | - | ## illustrated-message [_permalink_](#user-content-illustrated-message) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 404 kB | 13.53ms - 13.69ms | - | faster ✔
2% - 4%
0.23ms - 0.53ms | | branch | 393 kB | 13.86ms - 14.11ms | slower ❌
2% - 4%
0.23ms - 0.53ms | - | ## menu [_permalink_](#user-content-menu) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 475 kB | 211.23ms - 214.53ms | - | faster ✔
2% - 4%
4.46ms - 9.43ms | | branch | 463 kB | 217.96ms - 221.68ms | slower ❌
2% - 4%
4.46ms - 9.43ms | - | ## overlay [_permalink_](#user-content-overlay) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 694 kB | 428.26ms - 432.53ms | - | faster ✔
0% - 2%
1.73ms - 8.26ms | | branch | 670 kB | 432.91ms - 437.86ms | slower ❌
0% - 2%
1.73ms - 8.26ms | - | ### directive-test [_permalink_](#user-content-overlay-directive-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 773 kB | 22.29ms - 22.80ms | - | faster ✔
8% - 11%
1.89ms - 2.64ms | | branch | 772 kB | 24.54ms - 25.08ms | slower ❌
8% - 12%
1.89ms - 2.64ms | - | ### element-test [_permalink_](#user-content-overlay-element-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 763 kB | 351.78ms - 355.84ms | - | faster ✔
1% - 3%
4.58ms - 9.94ms | | branch | 750 kB | 359.32ms - 362.82ms | slower ❌
1% - 3%
4.58ms - 9.94ms | - | ### lazy-test [_permalink_](#user-content-overlay-lazy-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 561 kB | 40.64ms - 41.56ms | - | faster ✔
6% - 9%
2.65ms - 4.00ms | | branch | 548 kB | 43.93ms - 44.93ms | slower ❌
6% - 10%
2.65ms - 4.00ms | - | ## picker [_permalink_](#user-content-picker) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 513 kB | 544.58ms - 553.18ms | - | faster ✔
2% - 4%
10.55ms - 24.94ms | | branch | 500 kB | 560.86ms - 572.39ms | slower ❌
2% - 5%
10.55ms - 24.94ms | - | ## popover [_permalink_](#user-content-popover) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 384 kB | 11.53ms - 11.69ms | - | faster ✔
2% - 4%
0.24ms - 0.49ms | | branch | 372 kB | 11.88ms - 12.07ms | slower ❌
2% - 4%
0.24ms - 0.49ms | - | ## slider [_permalink_](#user-content-slider) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 480 kB | 76.75ms - 78.33ms | - | faster ✔
4% - 7%
2.84ms - 5.45ms | | branch | 467 kB | 80.65ms - 82.73ms | slower ❌
4% - 7%
2.84ms - 5.45ms | - | ## split-button [_permalink_](#user-content-split-button) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 723 kB | 1860.01ms - 1864.15ms | - | unsure 🔍
-0% - +0%
-5.41ms - +0.77ms | | branch | 710 kB | 1862.10ms - 1866.69ms | unsure 🔍
-0% - +0%
-0.77ms - +5.41ms | - | ## tooltip [_permalink_](#user-content-tooltip) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 550 kB | 33.64ms - 34.20ms | - | faster ✔
3% - 6%
1.15ms - 2.05ms | | branch | 548 kB | 35.17ms - 35.87ms | slower ❌
3% - 6%
1.15ms - 2.05ms | - | ### test-directive [_permalink_](#user-content-tooltip-test-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 533 kB | 22.76ms - 23.20ms | - | faster ✔
6% - 9%
1.48ms - 2.26ms | | branch | 532 kB | 24.53ms - 25.16ms | slower ❌
6% - 10%
1.48ms - 2.26ms | - | ### test-element [_permalink_](#user-content-tooltip-test-element) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 656 kB | 51.93ms - 52.91ms | - | faster ✔
4% - 7%
1.95ms - 3.65ms | | branch | 643 kB | 54.52ms - 55.92ms | slower ❌
4% - 7%
1.95ms - 3.65ms | - | ### test-lazy [_permalink_](#user-content-tooltip-test-lazy) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 632 kB | 41.77ms - 42.71ms | - | faster ✔
6% - 9%
2.57ms - 3.99ms | | branch | 619 kB | 44.99ms - 46.05ms | slower ❌
6% - 10%
2.57ms - 3.99ms | - | ## truncated [_permalink_](#user-content-truncated) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 528 kB | 54.65ms - 55.39ms | - | faster ✔
4% - 6%
2.35ms - 3.64ms | | branch | 516 kB | 57.49ms - 58.54ms | slower ❌
4% - 7%
2.35ms - 3.64ms | - |

Firefox

## accordion [_permalink_](#user-content-accordion) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 416 kB | 162.34ms - 168.14ms | - | faster ✔
5% - 10%
8.54ms - 17.42ms | | branch | 403 kB | 174.85ms - 181.59ms | slower ❌
5% - 11%
8.54ms - 17.42ms | - | ## action-bar [_permalink_](#user-content-action-bar) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 484 kB | 112.82ms - 118.74ms | - | faster ✔
0% - 7%
0.18ms - 8.58ms | | branch | 472 kB | 117.18ms - 123.14ms | slower ❌
0% - 7%
0.18ms - 8.58ms | - | ## action-menu [_permalink_](#user-content-action-menu) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 647 kB | 275.48ms - 278.24ms | - | faster ✔
13% - 14%
39.96ms - 45.72ms | | branch | 634 kB | 317.17ms - 322.23ms | slower ❌
14% - 17%
39.96ms - 45.72ms | - | ### test-directive [_permalink_](#user-content-action-menu-test-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 604 kB | 130.71ms - 134.65ms | - | unsure 🔍
-1% - +2%
-1.60ms - +2.68ms | | branch | 591 kB | 131.31ms - 132.97ms | unsure 🔍
-2% - +1%
-2.68ms - +1.60ms | - | ### test-lazy [_permalink_](#user-content-action-menu-test-lazy) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 603 kB | 150.34ms - 157.82ms | - | slower ❌
6% - 14%
9.13ms - 19.03ms | | branch | 590 kB | 136.76ms - 143.24ms | faster ✔
6% - 12%
9.13ms - 19.03ms | - | ### test-open-close-directive [_permalink_](#user-content-action-menu-test-open-close-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 789 kB | 1906.16ms - 1918.28ms | - | slower ❌
1% - 2%
17.39ms - 30.29ms | | branch | 777 kB | 1886.16ms - 1890.60ms | faster ✔
1% - 2%
17.39ms - 30.29ms | - | ### test-open-close [_permalink_](#user-content-action-menu-test-open-close) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 788 kB | 1883.83ms - 1889.29ms | - | unsure 🔍
-0% - +0%
-8.31ms - +0.15ms | | branch | 775 kB | 1887.41ms - 1893.87ms | unsure 🔍
-0% - +0%
-0.15ms - +8.31ms | - | ## card [_permalink_](#user-content-card) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 502 kB | 76.54ms - 83.26ms | - | unsure 🔍
-3% - +8%
-2.02ms - +6.54ms | | branch | 489 kB | 74.98ms - 80.30ms | unsure 🔍
-8% - +2%
-6.54ms - +2.02ms | - | ## combobox [_permalink_](#user-content-combobox) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 709 kB | 63.89ms - 69.71ms | - | slower ❌
3% - 14%
1.79ms - 8.33ms | | branch | 697 kB | 60.24ms - 63.24ms | faster ✔
3% - 12%
1.79ms - 8.33ms | - | ### light-dom-test [_permalink_](#user-content-combobox-light-dom-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 709 kB | 721.77ms - 733.95ms | - | slower ❌
1% - 4%
7.17ms - 29.71ms | | branch | 697 kB | 699.94ms - 718.90ms | faster ✔
1% - 4%
7.17ms - 29.71ms | - | ## illustrated-message [_permalink_](#user-content-illustrated-message) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 404 kB | 25.35ms - 26.45ms | - | unsure 🔍
-3% - +2%
-0.89ms - +0.57ms | | branch | 393 kB | 25.59ms - 26.53ms | unsure 🔍
-2% - +3%
-0.57ms - +0.89ms | - | ## menu [_permalink_](#user-content-menu) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 475 kB | 423.93ms - 436.27ms | - | faster ✔
1% - 5%
5.72ms - 24.16ms | | branch | 463 kB | 438.20ms - 451.88ms | slower ❌
1% - 6%
5.72ms - 24.16ms | - | ## overlay [_permalink_](#user-content-overlay) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 770 kB | 628.62ms - 640.86ms | - | slower ❌
2% - 5%
15.39ms - 31.29ms | | branch | 757 kB | 606.31ms - 616.49ms | faster ✔
2% - 5%
15.39ms - 31.29ms | - | ### directive-test [_permalink_](#user-content-overlay-directive-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 773 kB | 45.54ms - 47.02ms | - | faster ✔
3% - 7%
1.62ms - 3.38ms | | branch | 761 kB | 48.31ms - 49.25ms | slower ❌
3% - 7%
1.62ms - 3.38ms | - | ### element-test [_permalink_](#user-content-overlay-element-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 763 kB | 651.85ms - 659.91ms | - | slower ❌
3% - 6%
21.42ms - 35.74ms | | branch | 750 kB | 621.38ms - 633.22ms | faster ✔
3% - 5%
21.42ms - 35.74ms | - | ### lazy-test [_permalink_](#user-content-overlay-lazy-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 561 kB | 98.40ms - 107.72ms | - | slower ❌
5% - 15%
4.47ms - 14.01ms | | branch | 548 kB | 92.83ms - 94.81ms | faster ✔
5% - 13%
4.47ms - 14.01ms | - | ## picker [_permalink_](#user-content-picker) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 513 kB | 995.64ms - 1009.56ms | - | faster ✔
4% - 7%
39.04ms - 77.76ms | | branch | 500 kB | 1042.93ms - 1079.07ms | slower ❌
4% - 8%
39.04ms - 77.76ms | - | ## popover [_permalink_](#user-content-popover) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 384 kB | 28.03ms - 32.25ms | - | unsure 🔍
-10% - +7%
-3.22ms - +2.02ms | | branch | 372 kB | 29.18ms - 32.30ms | unsure 🔍
-7% - +11%
-2.02ms - +3.22ms | - | ## slider [_permalink_](#user-content-slider) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 480 kB | 164.27ms - 175.05ms | - | unsure 🔍
-5% - +2%
-9.50ms - +3.66ms | | branch | 467 kB | 168.82ms - 176.34ms | unsure 🔍
-2% - +6%
-3.66ms - +9.50ms | - | ## split-button [_permalink_](#user-content-split-button) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 723 kB | 1874.69ms - 1879.59ms | - | unsure 🔍
-0% - +0%
-4.31ms - +2.67ms | | branch | 710 kB | 1875.48ms - 1880.44ms | unsure 🔍
-0% - +0%
-2.67ms - +4.31ms | - | ## tooltip [_permalink_](#user-content-tooltip) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 656 kB | 79.40ms - 83.56ms | - | slower ❌
11% - 17%
7.65ms - 11.99ms | | branch | 643 kB | 71.03ms - 72.29ms | faster ✔
10% - 14%
7.65ms - 11.99ms | - | ### test-directive [_permalink_](#user-content-tooltip-test-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 533 kB | 45.85ms - 48.23ms | - | faster ✔
25% - 31%
15.41ms - 20.51ms | | branch | 521 kB | 62.74ms - 67.26ms | slower ❌
32% - 44%
15.41ms - 20.51ms | - | ### test-element [_permalink_](#user-content-tooltip-test-element) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 656 kB | 109.87ms - 118.25ms | - | faster ✔
4% - 11%
4.26ms - 13.98ms | | branch | 643 kB | 120.73ms - 125.63ms | slower ❌
3% - 13%
4.26ms - 13.98ms | - | ### test-lazy [_permalink_](#user-content-tooltip-test-lazy) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 632 kB | 93.19ms - 97.41ms | - | faster ✔
5% - 11%
4.86ms - 11.10ms | | branch | 619 kB | 100.98ms - 105.58ms | slower ❌
5% - 12%
4.86ms - 11.10ms | - | ## truncated [_permalink_](#user-content-truncated) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 528 kB | 101.25ms - 107.87ms | - | unsure 🔍
-6% - +3%
-6.37ms - +2.93ms | | branch | 516 kB | 103.01ms - 109.55ms | unsure 🔍
-3% - +6%
-2.93ms - +6.37ms | - |

adobe / spectrum-web-components