fix(progress-bar): removed duplicate label - Githubissues

adobe / spectrum-web-components

Spectrum Web Components

https://opensource.adobe.com/spectrum-web-components/

Apache License 2.0

1.21k stars 192 forks source link

fix(progress-bar): removed duplicate label #4493

Closed nikkimk closed 1 month ago

nikkimk commented 1 month ago

Description

Removes duplicate label from progress bar.

Related issue(s)

fixes #4225

How has this been tested?

[ ] Test case 1
1. Go here
2. Do this
[ ] Test case 2
1. Go here
2. Do this

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes. (Note: Testing won't allow an empty an empty label, so I can't test for this.)
[x] All new and existing tests passed.
[x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

github-actions[bot] commented 1 month ago

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs: - [High Contrast Mode | Medium | LTR](https://7f12d56b30d4a7d3deb9576b312b8592--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | LTR](https://9be4ca1439d4a9d1f543c52ba9bba7ea--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | RTL](https://37aa873b8b664b2cae2db306828ab7ca--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | LTR](https://777fb88def401eddaef869d3ff1d8b8f--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | RTL](https://5dbeaf26265077357e8d141b82bad6ec--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | LTR](https://950320b1b1a26506cd10dfc81bef8470--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | RTL](https://012e891947cc7bd9c3d8bd45de314038--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | LTR](https://283d3b9fc32e6e5c27fe7acf964c99c6--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | RTL](https://0aabfa10f61296418dc12f47b0b1b4c6--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | LTR](https://992a07bdb10c27141f23b0326cacb889--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | RTL](https://1449f90719eca0f67ab9dbd1780a03b8--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | LTR](https://2afe0ec5d479b967caf43b133ca3c13e--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | RTL](https://cecedcd49263fef413375dde9ad565fb--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | LTR](https://3e5191aa370d0ef409a64deb8b9d818b--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | RTL](https://3e867346937866017dabaefdb1280d1c--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | LTR](https://5efa9f1c3c42a99bdfcbbd8fba9d41da--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | RTL](https://57e0bf6a9127477d113433d120d1837b--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | LTR](https://cb882d0723e63b574f46c62598ee7e7a--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | RTL](https://382798825a5c4867bafdb7c01a4d1752--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | LTR](https://56b398dd50a6e9e8447f198d3e4ea2ab--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | RTL](https://38ea0f27a21145e6c8e02c18a00aae1f--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | LTR](https://7a172fa3b8d35f83ff6513687473e30b--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | RTL](https://8600afe365afae321e35038d335930e7--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | LTR](https://6f54289f8eeaec0408ec93a997ee037d--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | RTL](https://efc3497be5dd2a94cc9734f7645772b1--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | LTR](https://938fe5fe713b561f78f50f8e8e8a84ad--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | RTL](https://ddd28e224f540037e0c9056901b3a7fd--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | LTR](https://5df1953d7e457e0a770fc568bf102acc--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | RTL](https://00867a07520cd91d2016a925f441f2f4--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | LTR](https://f809d6244b58ac2fb50f9b671782f316--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | RTL](https://ce660ff324640b8c05fc5ed11d9f8721--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | LTR](https://e2caef14368b2a7e021e231390743e10--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | RTL](https://5badbe6092878980c0441055919268a0--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | LTR](https://f04aa55f8c72717f410ec90d943cb711--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | RTL](https://6bff3938765812a410e5cc901da8a1e4--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | LTR](https://f13d9de685127224ab11f0314432b7a4--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | RTL](https://110f591c86bc3cc091a54450f0b96f5a--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | LTR](https://66097f6611c6ce4bd57cad67c5c350db--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | RTL](https://a55368d18e24c07f6ee3699a96603f43--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | LTR](https://8ef40016445087a004dd99c5d11f02f0--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | RTL](https://64befb197e4bdb07a130d7d9d0ea62dc--spectrum-web-components.netlify.app/review/)

github-actions[bot] commented 1 month ago

Tachometer results

Chrome

## progress-bar [_permalink_](#user-content-progress-bar) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 407 kB | 29.48ms - 30.48ms | - | unsure 🔍
-2% - +2%
-0.46ms - +0.70ms | | branch | 395 kB | 29.56ms - 30.16ms | unsure 🔍
-2% - +2%
-0.70ms - +0.46ms | - |

Firefox

## progress-bar [_permalink_](#user-content-progress-bar) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 407 kB | 62.20ms - 66.00ms | - | unsure 🔍
-4% - +4%
-2.74ms - +2.58ms | | branch | 395 kB | 62.32ms - 66.04ms | unsure 🔍
-4% - +4%
-2.58ms - +2.74ms | - |