fix(number-field): updated number field to respect all locales

Description

Number-field was not respecting other locales than 'en'.

Related issue(s)

4483

Motivation and context

The function convertValueToNumber was not receiving correct input when locale was anything other than 'en'. In function stepBy earlier we were doing this.inputElement.value = value.toString(); which was not respecting locales. Thus to respect locales we are now formating the value like this this.inputElement.value = this.numberFormatter.format(value);

How has this been tested?

I wrote some tests in Number-field.test.ts Test here

Screenshots (if appropriate)

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] If my change required a change to the documentation, I have updated the documentation in this pull request.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

Branch preview

Visual regression test results

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

[Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category	Latest	Main	Branch
Total	225.537 kB	210.607 kB	210.275 kB 🏆
Scripts	54.654 kB	48.292 kB	47.999 kB 🏆
Stylesheet	35.059 kB	30.403 kB	30.397 kB 🏆
Document	5.998 kB	5.271 kB 🏆	5.273 kB
Font	126.871 kB	126.641 kB	126.606 kB 🏆

Request Count

Category	Latest	Main	Branch
Total	48	45	45
Scripts	37	37	37
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

Tachometer results

Chrome

## number-field [_permalink_](#user-content-number-field) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 523 kB | 65.78ms - 67.92ms | - | faster ✔
9% - 12%
6.59ms - 9.29ms | | branch | 511 kB | 73.96ms - 75.61ms | slower ❌
10% - 14%
6.59ms - 9.29ms | - | ## slider [_permalink_](#user-content-slider) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 480 kB | 74.70ms - 76.31ms | - | faster ✔
2% - 5%
1.23ms - 3.77ms | | branch | 467 kB | 77.02ms - 78.98ms | slower ❌
2% - 5%
1.23ms - 3.77ms | - |

Firefox

## number-field [_permalink_](#user-content-number-field) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 523 kB | 149.05ms - 154.95ms | - | faster ✔
6% - 11%
9.54ms - 17.74ms | | branch | 511 kB | 162.80ms - 168.48ms | slower ❌
6% - 12%
9.54ms - 17.74ms | - | ## slider [_permalink_](#user-content-slider) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 480 kB | 163.94ms - 170.50ms | - | faster ✔
2% - 8%
3.02ms - 14.22ms | | branch | 467 kB | 171.29ms - 180.39ms | slower ❌
2% - 9%
3.02ms - 14.22ms | - |

adobe / spectrum-web-components