adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.21k stars 192 forks source link

chore(tabs): update overflow icon color #4514

Closed Rajdeepc closed 1 month ago

Rajdeepc commented 1 month ago

Description

Surface --sp-tabs-overflow-icon-color to update overflow icon in sp-tabs-overflow

Motivation and context

How has this been tested?

Screenshots (if appropriate)

Screenshot 2024-05-29 at 1 34 42 PM

Types of changes

Checklist

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions[bot] commented 1 month ago

Branch preview

Visual regression test results When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs: - [High Contrast Mode | Medium | LTR](https://d1cb5011ad7a899f7fc4169dad48926d--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | LTR](https://f4ad97a18d4e5dc57bb37485076c3d83--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | RTL](https://57beaea9f17e782cc60b5969304ef92b--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | LTR](https://48843bceb5ebe2b918961e07d1b207cf--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | RTL](https://4da4513835c552a9627e3af2c351a56a--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | LTR](https://3dcee5710d6da6cd9cea024fe3fd7486--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | RTL](https://ed34ff6b17350f2085bc9f6c8e3eb4da--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | LTR](https://c1b1b0f487059d16b469f4f0f69cd0b1--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | RTL](https://a1e63195c92b833cb670bcad3954a4c7--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | LTR](https://2b2b7e7edb2bc3626f9a9ecdbfa69b68--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | RTL](https://d2956035f639ffc2c3b3a6df85030cf0--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | LTR](https://e4af0a89225f755c8dc2c4aadb5c0bab--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | RTL](https://01f5843c6219dc5bdc6ef1fc7423f959--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | LTR](https://5f7c77d77efb0ff2b1d00708a2ee4062--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | RTL](https://7ab38607ffbaeed494e8ae1fd0fe2155--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | LTR](https://92508c55b6c38865ee473643622e9811--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | RTL](https://15edce57d1cc6cf58e3629b469c11bab--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | LTR](https://32f34bbfb3b58a44ad820704a99364b6--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | RTL](https://9fb6350903878bdcb096cb30d7e96d13--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | LTR](https://d28056437e45185178d8dab1d515ff6c--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | RTL](https://e817456df8d6db9fa290ba67a10a1290--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | LTR](https://be2c6e8a15c0b7c02b6001be4821e77b--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | RTL](https://05d67029d747d7cb9b50a6d04d9756b5--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | LTR](https://4862df705f83dfd3631b26f129ec0cd2--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | RTL](https://7f0bf1709c6ae59e63f42c6a17dc1878--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | LTR](https://2e2afa6f397c666fee8419fae163416e--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | RTL](https://8a9aa639233e1268dc6a5eb7ad509fdd--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | LTR](https://cb8195ba99c8629baeb8dcc5e803ddf2--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | RTL](https://b29b49e9603f4f15c60a7e958935561a--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | LTR](https://baaa6b6f7b267166a57bb539c419f4c2--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | RTL](https://bc09986df1eb2ca8d9528d5e6f26e9a5--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | LTR](https://183e9899c3a71d8ffd96f28fac51206c--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | RTL](https://7d7fcf482cc4fe4632dce4e7c2c58291--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | LTR](https://e1e3e9c66a4d91a9084e7e77f668d6b6--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | RTL](https://9324be399631c5261fa6fb5ebbfbd6e7--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | LTR](https://2a238d269280e3586e0df501b5ecb278--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | RTL](https://8d56cb6ef1e323fca148456f8995eb7f--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | LTR](https://0d8b1c1a012277c19a0278f7e6040090--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | RTL](https://c914b1f82bd8a46fc5c5b35e43f2d66a--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | LTR](https://b9e315fc5c612de917b83593a237e17e--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | RTL](https://0b7012d6a8787522141ca6cc611a02a8--spectrum-web-components.netlify.app/review/)
github-actions[bot] commented 1 month ago

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this? [Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category Latest Main Branch
Total 222.564 kB 210.611 kB 🏆 210.738 kB
Scripts 54.623 kB 48.244 kB 🏆 48.427 kB
Stylesheet 34.969 kB 30.44 kB 30.386 kB 🏆
Document 5.981 kB 5.265 kB 🏆 5.275 kB
Font 126.991 kB 126.662 kB 126.65 kB 🏆

Request Count

Category Latest Main Branch
Total 45 45 45
Scripts 37 37 37
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2
github-actions[bot] commented 1 month ago

Tachometer results

Chrome ## tabs [_permalink_](#user-content-tabs) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 424 kB | 103.90ms - 104.95ms | - | faster ✔
2% - 3%
1.97ms - 3.74ms | | branch | 411 kB | 106.57ms - 107.99ms | slower ❌
2% - 4%
1.97ms - 3.74ms | - | ## top-nav [_permalink_](#user-content-top-nav) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 429 kB | 38.05ms - 39.64ms | - | faster ✔
2% - 7%
0.68ms - 2.93ms | | branch | 417 kB | 39.85ms - 41.44ms | slower ❌
2% - 8%
0.68ms - 2.93ms | - |
Firefox ## tabs [_permalink_](#user-content-tabs) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 424 kB | 196.30ms - 203.38ms | - | unsure 🔍
-3% - +2%
-6.06ms - +3.38ms | | branch | 411 kB | 198.07ms - 204.29ms | unsure 🔍
-2% - +3%
-3.38ms - +6.06ms | - | ## top-nav [_permalink_](#user-content-top-nav) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 429 kB | 83.88ms - 90.16ms | - | unsure 🔍
-8% - +2%
-7.26ms - +1.46ms | | branch | 417 kB | 86.90ms - 92.94ms | unsure 🔍
-2% - +8%
-1.46ms - +7.26ms | - |
blunteshwar commented 1 month ago

I noticed that some sections of this PR are not fully completed. Could you please fill out all the necessary details and ensure that everything is properly documented?

Rajdeepc commented 1 month ago

I noticed that some sections of this PR are not fully completed. Could you please fill out all the necessary details and ensure that everything is properly documented?

Good Point!