adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.21k stars 192 forks source link

[Bug]: `sp-number-field` cannot be styled using `--mod-*` variables #4527

Closed AndreeaMadalinaMarica closed 2 weeks ago

AndreeaMadalinaMarica commented 1 month ago

Code of conduct

Impacted component(s)

sp-number-field

Expected behavior

Use --mod-* variables such as --mod-textfield-border-width or --mod-textfield-border-color in order to style sp-number-field that has hide-stepper attribute and not quiet. The expected behaviour is that the appearance of sp-number-field according to --mod-* variables.

Actual behavior

The actul behaviour is that the appearance of sp-number-field remains unchanged. The root cause is probably here. For :host([hide-stepper]:not([quiet])) the number field input border cannot be overridden with a --mod-*override.

Screenshots

No response

What browsers are you seeing the problem in?

Firefox, Chrome, Safari, Microsoft Edge

How can we reproduce this issue?

  1. Go to '...'
  2. Click on '....'
  3. Scroll to '....'
  4. Check console
  5. See error

Sample code that illustrates the problem

No response

Logs taken while reproducing problem

No response