fix(overlay): plug mememory leak from lastOverlay

[pinkhominid]

Description

Related issue(s)

-

Motivation and context

How has this been tested?

• [ ] Test case 1
  1. Go here
  2. Do this
• [ ] Test case 2
  1. Go here
  2. Do this

Screenshots (if appropriate)

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [ ] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

• [ ] I have signed the Adobe Open Source CLA.
• [ ] My code follows the code style of this project.
• [ ] If my change required a change to the documentation, I have updated the documentation in this pull request.
• [ ] I have read the CONTRIBUTING document.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.
• [ ] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

[github-actions[bot]]

Branch preview

• Documentation Site
• Storybook

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs: - [High Contrast Mode | Medium | LTR](https://09cf8e02d88f1ee482908f475766f5a7--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | LTR](https://e8f24ee34dfb2897d4fc2cb1eeee6116--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Medium | RTL](https://31fd6f9a7dd7522d2ba408492a325ea2--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | LTR](https://073cb6be3674f91a9017c19d06971072--spectrum-web-components.netlify.app/review/) - [Spectrum | Lightest | Large | RTL](https://249d56b381ff48039788968719127415--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | LTR](https://541eb909611dd6bce383311b9a0a624d--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Medium | RTL](https://31d7ea3ee1e432694a9e014111b72d3e--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | LTR](https://083924ce3e53f11085c27226e8b884de--spectrum-web-components.netlify.app/review/) - [Spectrum | Light | Large | RTL](https://3907224727738f9a29710ac228d247f7--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | LTR](https://d0711d096022cf78db8d58a23f4703ed--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Medium | RTL](https://96a7446cfbc497b9d9a65c1a9b20b669--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | LTR](https://a0ace2db0cb27a3ca53c536cbc2868fa--spectrum-web-components.netlify.app/review/) - [Spectrum | Dark | Large | RTL](https://39a89cf6f3c50b103b4579321cc820ef--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | LTR](https://3d62c5ae6fca0fbdd8f67a7f883c34b2--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Medium | RTL](https://842899ab98a2e8c82e6408a92f8ce12b--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | LTR](https://a411094d07d22f75604a652c3156751a--spectrum-web-components.netlify.app/review/) - [Spectrum | Darkest | Large | RTL](https://01767e4a3342499385b1ad1a1da9686c--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | LTR](https://a78f92503437b4b9cf5a1e3b492d5877--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Medium | RTL](https://97a925b033e383f4135d2f225a213fdf--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | LTR](https://87b372716d2fbda37b9b47d7a80a21ce--spectrum-web-components.netlify.app/review/) - [Express | Lightest | Large | RTL](https://af6dcd5f7e10192bc3b5fefc3aeb18a5--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | LTR](https://f70e240aab054ef272f8e387ccd18c64--spectrum-web-components.netlify.app/review/) - [Express | Light | Medium | RTL](https://cd62593954f5bdfafb7189cf7790e725--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | LTR](https://0886a1607d1a7a258f7321a38e12d8b2--spectrum-web-components.netlify.app/review/) - [Express | Light | Large | RTL](https://7ee70f8df79b2c18c4f92d8fb4eba13b--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | LTR](https://e777c6244141c78747f9af9e86f264f0--spectrum-web-components.netlify.app/review/) - [Express | Dark | Medium | RTL](https://adcb29e0abf7a35951843c65152ee155--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | LTR](https://04a1dbdd455c32ce7ddc9293580ffb88--spectrum-web-components.netlify.app/review/) - [Express | Dark | Large | RTL](https://fe572a9a11dc5ca5fa4e99e75803cfde--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | LTR](https://a3dd6d0fbb657d42d3716871bb22ee7a--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Medium | RTL](https://8229ac8c4fa7c34c9dd30d3ced83d012--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | LTR](https://51e6d32d535ca0a50faf987dce86f168--spectrum-web-components.netlify.app/review/) - [Express | Darkest | Large | RTL](https://dbba40b43488222ae6540c8fa24db912--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | LTR](https://d0c487b9884683a47bf34cb5694eb01e--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Medium | RTL](https://21eb2792b9dde3d447bed5fde4b0e29b--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | LTR](https://f79f36d8087fce0efc3859f7183cc94f--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Light | Large | RTL](https://39dc60be042b9d3130dbc234e9d715be--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | LTR](https://39151ae774bb9ebeef705ca553ce0753--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Medium | RTL](https://9dfaa5e2f2b68fac4e93abe6bb8ad92f--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | LTR](https://b3a021cdfed9917480ab89ed61f9ee03--spectrum-web-components.netlify.app/review/) - [Spectrum-two | Dark | Large | RTL](https://0b8a00dc7f6a50e731790a8af6455004--spectrum-web-components.netlify.app/review/)

[github-actions[bot]]

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	0.99
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

[Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category	Latest	Main	Branch
Total	221.837 kB	210.754 kB 🏆	210.908 kB
Scripts	54.049 kB	48.441 kB 🏆	48.546 kB
Stylesheet	34.909 kB	30.394 kB 🏆	30.451 kB
Document	5.996 kB	5.293 kB 🏆	5.296 kB
Font	126.883 kB	126.626 kB	126.615 kB 🏆

Request Count

Category	Latest	Main	Branch
Total	45	45	45
Scripts	37	37	37
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

[github-actions[bot]]

Tachometer results

Chrome

## action-bar [_permalink_](#user-content-action-bar) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 485 kB | 50.63ms - 53.19ms | - | unsure 🔍
-6% - +1%
-3.05ms - +0.36ms | | branch | 472 kB | 52.13ms - 54.38ms | unsure 🔍
-1% - +6%
-0.36ms - +3.05ms | - | ## action-menu [_permalink_](#user-content-action-menu) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 647 kB | 133.21ms - 135.82ms | - | faster ✔
6% - 8%
7.87ms - 11.63ms | | branch | 634 kB | 142.91ms - 145.62ms | slower ❌
6% - 9%
7.87ms - 11.63ms | - | ### test-directive [_permalink_](#user-content-action-menu-test-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 604 kB | 61.24ms - 64.75ms | - | faster ✔
3% - 9%
1.84ms - 5.75ms | | branch | 591 kB | 65.94ms - 67.65ms | slower ❌
3% - 9%
1.84ms - 5.75ms | - | ### test-lazy [_permalink_](#user-content-action-menu-test-lazy) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 603 kB | 60.28ms - 61.70ms | - | faster ✔
4% - 7%
2.48ms - 4.51ms | | branch | 590 kB | 63.76ms - 65.20ms | slower ❌
4% - 7%
2.48ms - 4.51ms | - | ### test-open-close-directive [_permalink_](#user-content-action-menu-test-open-close-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 790 kB | 1873.38ms - 1876.14ms | - | unsure 🔍
-0% - +0%
-1.89ms - +2.26ms | | branch | 777 kB | 1873.03ms - 1876.12ms | unsure 🔍
-0% - +0%
-2.26ms - +1.89ms | - | ### test-open-close [_permalink_](#user-content-action-menu-test-open-close) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 788 kB | 1859.40ms - 1861.90ms | - | unsure 🔍
-0% - +0%
-2.34ms - +1.30ms | | branch | 775 kB | 1859.84ms - 1862.50ms | unsure 🔍
-0% - +0%
-1.30ms - +2.34ms | - | ## combobox [_permalink_](#user-content-combobox) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 710 kB | 34.90ms - 35.27ms | - | faster ✔
6% - 8%
2.25ms - 3.03ms | | branch | 697 kB | 37.38ms - 38.06ms | slower ❌
6% - 9%
2.25ms - 3.03ms | - | ### light-dom-test [_permalink_](#user-content-combobox-light-dom-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 710 kB | 382.89ms - 388.47ms | - | faster ✔
3% - 5%
11.64ms - 19.27ms | | branch | 698 kB | 398.53ms - 403.74ms | slower ❌
3% - 5%
11.64ms - 19.27ms | - |

Firefox

## action-bar [_permalink_](#user-content-action-bar) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 485 kB | 109.40ms - 115.08ms | - | unsure 🔍
-6% - +1%
-6.76ms - +1.64ms | | branch | 472 kB | 111.70ms - 117.90ms | unsure 🔍
-2% - +6%
-1.64ms - +6.76ms | - | ## action-menu [_permalink_](#user-content-action-menu) ### test-basic | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 647 kB | 273.10ms - 276.94ms | - | faster ✔
12% - 14%
38.14ms - 43.98ms | | branch | 634 kB | 313.88ms - 318.28ms | slower ❌
14% - 16%
38.14ms - 43.98ms | - | ### test-directive [_permalink_](#user-content-action-menu-test-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 604 kB | 128.21ms - 131.31ms | - | unsure 🔍
-2% - +0%
-3.22ms - +0.30ms | | branch | 591 kB | 130.40ms - 132.04ms | unsure 🔍
-0% - +2%
-0.30ms - +3.22ms | - | ### test-lazy [_permalink_](#user-content-action-menu-test-lazy) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 603 kB | 153.30ms - 159.58ms | - | slower ❌
10% - 16%
13.98ms - 21.74ms | | branch | 590 kB | 136.29ms - 140.87ms | faster ✔
9% - 14%
13.98ms - 21.74ms | - | ### test-open-close-directive [_permalink_](#user-content-action-menu-test-open-close-directive) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 790 kB | 1910.81ms - 1920.43ms | - | slower ❌
1% - 2%
20.35ms - 31.37ms | | branch | 777 kB | 1887.08ms - 1892.44ms | faster ✔
1% - 2%
20.35ms - 31.37ms | - | ### test-open-close [_permalink_](#user-content-action-menu-test-open-close) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 788 kB | 1881.89ms - 1887.35ms | - | unsure 🔍
-0% - +0%
-3.90ms - +2.82ms | | branch | 775 kB | 1883.21ms - 1887.11ms | unsure 🔍
-0% - +0%
-2.82ms - +3.90ms | - | ## combobox [_permalink_](#user-content-combobox) ### basic-test | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 710 kB | 61.63ms - 67.17ms | - | slower ❌
0% - 10%
0.21ms - 6.03ms | | branch | 697 kB | 60.40ms - 62.16ms | faster ✔
1% - 9%
0.21ms - 6.03ms | - | ### light-dom-test [_permalink_](#user-content-combobox-light-dom-test) | Version | Bytes | Avg Time | vs remote | vs branch | |---|---|---|---|---| | npm latest | 710 kB | 717.63ms - 741.73ms | - | slower ❌
1% - 5%
8.94ms - 36.10ms | | branch | 698 kB | 700.89ms - 713.43ms | faster ✔
1% - 5%
8.94ms - 36.10ms | - |