chore: skip restore_cache step

rubencarvalho commented 2 weeks ago

Description

Skipping the yarn caching in CircleCI until we stop seeing transitive dependency errors. Follow-up from https://github.com/adobe/spectrum-web-components/pull/4911

Motivation and context

We still see some PRs with test-chromium failing when restoring the cache, even though we already bumped it.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[x] If my change required a change to the documentation, I have updated the documentation in this pull request.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

github-actions[bot] commented 2 weeks ago

Branch preview

github-actions[bot] commented 2 weeks ago

Tachometer results

Currently, no packages are changed by this PR...

github-actions[bot] commented 2 weeks ago

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.99	0.99	1
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

[Lighthouse](https://github.com/GoogleChrome/lighthouse) scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but *note that the SEO scores on Netlify URLs are artifically constrained to 0.92.*

Transfer Size

Category	Latest	Main	Branch
Total	251.784 kB	236.607 kB 🏆	236.835 kB
Scripts	61.735 kB	54.278 kB 🏆	54.341 kB
Stylesheet	53.94 kB	47.845 kB 🏆	48.064 kB
Document	6.19 kB	5.496 kB	5.436 kB 🏆
Font	126.898 kB	126.596 kB 🏆	126.642 kB

Request Count

Category	Latest	Main	Branch
Total	52	52	52
Scripts	41	41	41
Stylesheet	5	5	5
Document	1	1	1
Font	2	2	2

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 11723796027

Details

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 98.189%

Totals
Change from base Build 11721446813:	0.0%
Covered Lines:	32313
Relevant Lines:	32735

💛 - Coveralls

rubencarvalho commented 2 weeks ago

I assume there is a subsequent PR to undo this then?

Yes, priority now is to unblock the pipeline. Once we the corrupt cache goes away (I hope with the next batch of open PRs) we can add this back again. This caching only saves us around 45 seconds of build time, so it is not very impactful.

adobe / spectrum-web-components