search

adobe / spectrum-web-components

Spectrum Web Components
https://opensource.adobe.com/spectrum-web-components/
Apache License 2.0
1.22k stars 193 forks source link

An in-range update of puppeteer is breaking the build 🚨 #692

Closed greenkeeper[bot] closed 4 years ago

greenkeeper[bot] commented 4 years ago

🚨 Reminder! Less than one month left to migrate your repositories over to Snyk before Greenkeeper says goodbye on June 3rd! 💜 🚚💨 💚

Find out how to migrate to Snyk at greenkeeper.io

The devDependency puppeteer was updated from 3.0.4 to 3.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

puppeteer is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details - ❌ **ci/circleci: build:** Your tests failed on CircleCI ([Details](https://circleci.com/gh/adobe/spectrum-web-components/10296?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)). - ❌ **build:** * [build](https://circleci.com/gh/adobe/spectrum-web-components/10296?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link) - Failed * visual-dark-medium - Blocked * visual-darkest-large - Blocked * visual-light-large - Blocked * visual-darkest-medium - Blocked * visual-dark-large - Blocked * visual-light-medium - Blocked * visual-lightest-medium - Blocked * visual-lightest-large - Blocked
Release Notes for v3.1.0

Raw notes

8ba3675 - chore: mark version v3.1.0 (#5883)
a17bd89 - feat: add securityDetails.subjectAlternativeNames() #5628 (#5881)
e823289 - feat(chromium): roll Chromium to r756035 (#5879)
ad3613d - docs(contributing): clarify list of Chromium versions (#5878)
dc26b8d - docs(examples): add cucumber-puppeteer-example for integration testing (#5875)
3e76554 - chore: fix async dialog specs when they fail (#5859)
b2552e4 - chore: restore page.setUserAgent test (#5868)
39f1b13 - chore: extract Request and Response into its own module (#5861)
b510c35 - chore: fetch Firefox from JSON source instead of RegExp (#5864)
69c38fc - chore: extract ConsoleMessage and FileChooser into its own module (#5856)
0aba6df - chore: force Mocha to exit on CI (#5862)
9368edb - chore: upgrade TypeScript to 3.9 (#5860)
5f42547 - chore: extract SecurityDetails into its own module (#5858)
f5d2597 - chore: add running TSC to test README (#5852)
c6d01c9 - chore: extract BrowserRunner into its own module (#5850)
b38bb43 - Warn when given unsupported product name. (#5845)
6099272 - chore: add @types/proxy-from-env (#5831)
5343c7a - chore: private-ise src/Accessibility.ts (#5832)
ce09742 - feat: add more options to check_availability script (#5827)
5103540 - chore: add command to run eslint with --fix flag (#5829)
49ce659 - chore: remove src/TaskQueue (#5826)
4fdb1e3 - chore: add Prettier (#5825)
ae576af - chore: mark v3.0.4-post (#5824)

Commits

The new version differs by 23 commits.

  • 8ba3675 chore: mark version v3.1.0 (#5883)
  • a17bd89 feat: add securityDetails.subjectAlternativeNames() #5628 (#5881)
  • e823289 feat(chromium): roll Chromium to r756035 (#5879)
  • ad3613d docs(contributing): clarify list of Chromium versions (#5878)
  • dc26b8d docs(examples): add cucumber-puppeteer-example for integration testing (#5875)
  • 3e76554 chore: fix async dialog specs when they fail (#5859)
  • b2552e4 chore: restore page.setUserAgent test (#5868)
  • 39f1b13 chore: extract Request and Response into its own module (#5861)
  • b510c35 chore: fetch Firefox from JSON source instead of RegExp (#5864)
  • 69c38fc chore: extract ConsoleMessage and FileChooser into its own module (#5856)
  • 0aba6df chore: force Mocha to exit on CI (#5862)
  • 9368edb chore: upgrade TypeScript to 3.9 (#5860)
  • 5f42547 chore: extract SecurityDetails into its own module (#5858)
  • f5d2597 chore: add running TSC to test README (#5852)
  • c6d01c9 chore: extract BrowserRunner into its own module (#5850)

There are 23 commits in total.

See the full diff

FAQ and help There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 4 years ago

After pinning to 3.0.4 your tests are passing again. Downgrade this dependency 📌.

Westbrook commented 4 years ago

This version of Puppeteer causes an unexpected visual regression: image I believe that we should wait until it is corrected in a later version to update.