search

adobe / theblog

Apache License 2.0
7 stars 14 forks source link

Cleaning up icons folder #642

Closed elaineskpt closed 3 years ago

elaineskpt commented 3 years ago

Based on Issue https://github.com/adobe/theblog/issues/496 kptdobe commented on Nov 3, 2020 Apart from https://github.com/adobe/theblog/blob/master/icons/adobe.svg, does someone use icons ? I doubt since most of them are outdated or even wrong like:

https://github.com/adobe/theblog/blob/master/icons/creativecloud.svg https://github.com/adobe/theblog/blob/master/icons/creative-cloud.svg Probably bug in the importer...

I think we can remove most of them.

Leaving only following icons that are being using in head.html, all other were not being used in any file

<link rel="icon" type="image/svg+xml" href="/icons/adobe.svg"/>
<link rel="alternate icon" href="https://www.adobe.com/favicon.ico"/>
<link rel="apple-touch-icon" href="/icons/apple-touch-icon.png"/>
<link rel="apple-touch-icon" sizes="120x120" href="/icons/apple-touch-icon-120x120.png"/>
<link rel="apple-touch-icon" sizes="152x152" href="/icons/apple-touch-icon-152x152.png"/>
<link rel="apple-touch-icon" sizes="167x167" href="/icons/apple-touch-icon-167x167.png"/>
<link rel="apple-touch-icon" sizes="180x180" href="/icons/apple-touch-icon-180x180.png"/>
<link rel="apple-touch-icon-precomposed" href="/icons/apple-touch-icon-precomposed.png"/>
kptdobe commented 3 years ago

Thanks @elaineskpt. Sorry for the long delay, finally took the time to review this PR!