search

adobe / theblog

Apache License 2.0
7 stars 14 forks source link

Log a warning when topic is not found in taxonomy #703

Closed dominique-pfister closed 1 year ago

dominique-pfister commented 3 years ago

While looking at a topic that returns no articles, I noticed that the code:

https://github.com/adobe/theblog/blob/dba8b8a1770375b96c6dbb7b6fa0d501fcfdf71f/scripts/v2/common.js#L622

and lines following silently fill in an empty topic so the code keeps working for a topic that isn't found. Might be worth logging a warning (or some other indication) which would help detecting a missing topic quicker.

kptdobe commented 3 years ago

I would not qualify this as a "bug" but I agree!