Update Analytics Android and iOS bundled SDKs

adobe / xamarin-acpanalytics

Adobe Experience Platform - Analytics plugin for Xamarin apps.

Apache License 2.0

2 stars 8 forks source link

Update Analytics Android and iOS bundled SDKs #19

Closed spoorthipujariadobe closed 2 years ago

spoorthipujariadobe commented 2 years ago

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have signed the Adobe Open Source CLA.
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

spoorthipujariadobe commented 2 years ago

Do we need to update the version in these two files? https://github.com/spoorthipujariadobe/xamarin-acpanalytics/blob/update_analytics_to_latest/src/Adobe.ACPAnalytics.tvOS/Properties/AssemblyInfo.cs#L28

https://github.com/spoorthipujariadobe/xamarin-acpanalytics/blob/update_analytics_to_latest/src/Adobe.ACPAnalytics.iOS/Properties/AssemblyInfo.cs#L40

I didn't update the tvOS SDK as the newer tvOS Core SDK was giving errors in Xamarin. Since no customers are using it yet, we might just leave it as if till we get a request.

cacheung commented 2 years ago

How about this file? https://github.com/spoorthipujariadobe/xamarin-acpanalytics/blob/update_analytics_to_latest/src/Adobe.ACPAnalytics.iOS/Properties/AssemblyInfo.cs#L40

spoorthipujariadobe commented 2 years ago

How about this file? https://github.com/spoorthipujariadobe/xamarin-acpanalytics/blob/update_analytics_to_latest/src/Adobe.ACPAnalytics.iOS/Properties/AssemblyInfo.cs#L40

Will update that, thank you

spoorthipujariadobe commented 2 years ago

Do we need to update the version in these two files? https://github.com/spoorthipujariadobe/xamarin-acpanalytics/blob/update_analytics_to_latest/src/Adobe.ACPAnalytics.tvOS/Properties/AssemblyInfo.cs#L28 https://github.com/spoorthipujariadobe/xamarin-acpanalytics/blob/update_analytics_to_latest/src/Adobe.ACPAnalytics.iOS/Properties/AssemblyInfo.cs#L40

I didn't update the tvOS SDK as the newer tvOS Core SDK was giving errors in Xamarin. Since no customers are using it yet, we might just leave it as if till we get a request.

Was able to fix tvOS issues by clearing local cache. Updated all assembly files as well. Thank you!