adobecom / firefly

Apache License 2.0
0 stars 2 forks source link

Firefly site showed the Watch Live button in the navigation #108

Open kunwarsaluja opened 1 month ago

kunwarsaluja commented 1 month ago

Firefly site showed the Watch Live button in the navigation

Screenshot 2024-07-23 at 4 20 15 PM

kunwarsaluja commented 1 month ago

@tom-hightower do you know the conditions on when this Watch Live button appears on the homepage navigation ? I don't see any styling for this on the Figma file ?

tom-hightower commented 1 month ago

This is controlled by the firefly-live-event feature flag

kunwarsaluja commented 1 month ago

@kailasnadh790 another one to tackle later using feature flags.

@tom-hightower Are there anymore such unknowns we are not aware of or totally missing but are being driven by feature flags and we should account for them on the homepage ?

tom-hightower commented 1 month ago

There are several features that are feature flag driven, I'm not sure which ones you're aware of. Example:

Is your current awareness based on the <Home /> and <Navbar /> components in the current homepage section of our codebase? I think that this is probably the best way to check the display logic

kunwarsaluja commented 1 month ago

Thanks @tom-hightower this is helpful. We were not aware of all these cases so now considering these 1:1 basis for the MVP.

We missed you in the last meeting but we did request Daosheng/Sarah to help us here to move in the right direction for all such use-cases which are not accounted in the figma file or embedded deep in the code and also provide an api/library which is readily consumable for identifying a user state (personal/enterprise profile, entitlements, these extra feature flags) and more.