adobecom / firefly

Apache License 2.0
0 stars 2 forks source link

enforce superhero lcp #91

Open shsteimer opened 1 week ago

shsteimer commented 1 week ago

https://better-superhero--firefly--adobecom.aem.live/

see comparison at https://thinktanked.org/tools/deep-psi/deep-psi.html?url1=https%3A%2F%2Fbetter-superhero--firefly--adobecom.aem.live&url2=https%3A%2F%2Fmain--firefly--adobecom.aem.live

basically, this ensures the LCP image finishes loading before anything else can load (a feature from boilerplate conspicuously absent from MILO). I don't like having to do this in that block, but not sure where else to put it.

aem-code-sync[bot] commented 1 week ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [f8eae89](https://github.com/adobecom/firefly/commit/f8eae89e5b34ab492079e6c14824a67169e88b11) :white_check_mark: (latest) * [b980f58](https://github.com/adobecom/firefly/commit/b980f5833e6fd63b20149d1e7943a308d2e25787) :white_check_mark:
aem-code-sync[bot] commented 1 week ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI