adobecom / firefly

Apache License 2.0
0 stars 2 forks source link

I18n alternate impl | re-using localized content from firefly project #93

Open kunwarsaluja opened 1 week ago

kunwarsaluja commented 1 week ago

After : https://i18n-alternative--firefly--adobecom.hlx.page/drafts/kunwar/community

Current impl in the main branch is using spreadsheets where all json files from adjusted to create a spreadsheet and exposed as json but this wont help in maintaining a single source truth.

This is an alternate implementation for localization of content where the key values pairs are being fetched from language json files within github. These json files are synced from firefly project everyday (git.corp) so keys are in sync This is to done to maintain the single source of truth and avoiding maintenance of spreadsheet which might be cumbersome task.

Milo Localization workflow can't be used on our spreadsheet due reasons

Also included,

aem-code-sync[bot] commented 1 week ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [b2ddda0](https://github.com/adobecom/firefly/commit/b2ddda04fb9fccfda8da21fb07e43e89fb3f3e19) :white_check_mark: (latest) * [12b8b2b](https://github.com/adobecom/firefly/commit/12b8b2b462c9112e71eac9d6220a07317e5f21ca) :white_check_mark: * [a19b251](https://github.com/adobecom/firefly/commit/a19b251924d97444b9879b9e7deea8ff05075bee) :white_check_mark: * [e92fe76](https://github.com/adobecom/firefly/commit/e92fe76e6db5add99f7066376f9809b486038996) :white_check_mark: * [321a2cd](https://github.com/adobecom/firefly/commit/321a2cdc4af9e36d04d2b4cc8dea7f3734146ec2) :white_check_mark: * [698f3dc](https://github.com/adobecom/firefly/commit/698f3dcf153227025f8e9b6282a719c321d0cc23) :white_check_mark: * [e23a416](https://github.com/adobecom/firefly/commit/e23a4161bf43a457bbcaf5b6abb25cee8e8840de) :white_check_mark: * [01d43b3](https://github.com/adobecom/firefly/commit/01d43b3a1d929328117a94dbb828c792d5546ddf) :white_check_mark: * [8815a6c](https://github.com/adobecom/firefly/commit/8815a6cbb88313084fd284ded1398012687dc799) :white_check_mark: * [b94782f](https://github.com/adobecom/firefly/commit/b94782f9abf35324cca1753f68e43beefd8ecbc6) :white_check_mark: * [42678b3](https://github.com/adobecom/firefly/commit/42678b3945e8bfd9c1f803c895107b4735d4f01b) :white_check_mark: * [1d76557](https://github.com/adobecom/firefly/commit/1d7655717f09f24cec296daf2228fa3edd1e27ef) :white_check_mark: * [44356af](https://github.com/adobecom/firefly/commit/44356af0ff4def0ac692f5365eaff20b9cc24d5d) :white_check_mark: * [e22358a](https://github.com/adobecom/firefly/commit/e22358aa651e8314b735fd200e113f3cdbd7816b) :white_check_mark: * [0cc64c8](https://github.com/adobecom/firefly/commit/0cc64c85bd53379162a60896a30f7fe89cff04c4) :white_check_mark: * [3ca7fae](https://github.com/adobecom/firefly/commit/3ca7fae0bed9431cfe81d92bfe6eb7986f99ebdf) :white_check_mark: * [763ed80](https://github.com/adobecom/firefly/commit/763ed80acdaff26d5cee1ba807b5a58f2261bac5) :white_check_mark: * [26b9bf3](https://github.com/adobecom/firefly/commit/26b9bf33739926ff7a609202d2e43e1fe9b4ef5d) :white_check_mark: * [d5fccc4](https://github.com/adobecom/firefly/commit/d5fccc4e3c80dd8f8afb42fb23b693ac61ceb4fd) :white_check_mark: * [175357b](https://github.com/adobecom/firefly/commit/175357b1e53aa14a3d0ebedce61fc2917e00123a) :white_check_mark: * [f1c8d40](https://github.com/adobecom/firefly/commit/f1c8d406c92342592160fc885158a18d6fa69204) :white_check_mark: * [e8ed4c0](https://github.com/adobecom/firefly/commit/e8ed4c0aa6e14da4a74319b667b9d17779d87435) :white_check_mark: * [c6fa5e9](https://github.com/adobecom/firefly/commit/c6fa5e979d20b6302d3d6caaf2a0177471fba59d) :white_check_mark: * [c7cc806](https://github.com/adobecom/firefly/commit/c7cc80677cd60a27337c8b2c67d505ffa69ea54b) :white_check_mark: * [ba75162](https://github.com/adobecom/firefly/commit/ba751622ac71145fd9380c0879e459e271723b84) :white_check_mark: * [9f26d2e](https://github.com/adobecom/firefly/commit/9f26d2e721fea9b7a657a1c3e02ec6ed34aedce1) :white_check_mark: * [2c68b5d](https://github.com/adobecom/firefly/commit/2c68b5dc94f650ea54ab210be4a0792ff50daee5) :white_check_mark: * [1da0934](https://github.com/adobecom/firefly/commit/1da0934d30f9be06e75c483473cb41869a7972cd) :white_check_mark: * [70459ef](https://github.com/adobecom/firefly/commit/70459efa0081d44f029e67d1539dbf4a08df3254) :white_check_mark: * [6236595](https://github.com/adobecom/firefly/commit/6236595089b436c6669e947c514a667092a03cbf) :white_check_mark:
aem-code-sync[bot] commented 1 week ago
Page Scores Audits Google
/drafts/kunwar/community PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI