adoconnection / RazorEngineCore

.NET6 Razor Template Engine
MIT License
565 stars 84 forks source link

Fill the incomplete usage of async methods. #138

Closed A9G-Data-Droid closed 7 months ago

A9G-Data-Droid commented 7 months ago

I apologize if I don't know the historical reasons why not all the methods are async. I did a quick review and wanted to share my notes. I hope some of these changes useful.

All tests pass without modification.

adoconnection commented 7 months ago

Thanks! Improvements are always welcome 🚀 You mean ReadLong and WriteLong? Well they manipute few bytes so I thought its insignificant, no other reasons